Open
Conversation
with routing
updated routing to fall back to 'users' put a routes enum in, added in the create user component
added enum for app routes and seperate enum for API routes,
added generic response interface based off of what's available on the two endpoints and what I've seen on the postman, can be implented by response classes as needed
with columns rows and pagination, material theme and striped
because it comes with custom pagination built in
imported required angular modules, created post method in service, added in some global styling files, made form responsive
added username validation and email validation, required validation, navigation back to previous page
and also don't display pagination on mobile
added custom translation keys to mat paginator placed paginator on top of table
colored the snacbars also
added all missing imports to make the basic specs run, added firefox as browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.