Johanna modifs #56
Open
Johanna modifs #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 36-37 : Style of margin modified from 10px to 2px. Aim to adapt the app size to smaller PC screens.
…the catchment based on the outlet.
to make the button leu and standout more
…chargement / information), de la couleur du fond et du texte, plus mise en gras.
…tation de sa taille
… sera à documenter avec une vraie description. + légère modification de la position de button de sélection qui lui est associé.
…ire sur le plot_crosssection, pour cela il est passé en argument dans l'appel de la fonction cr_profile_main avec la valeur r_val$swath_data_dgo.
…the tooltip_label in fct_map. Proposed_class select the name of the selected
…re observeEvent line 426 "r_val$map_proxy" parameter and use it to display the class selected on mouseover
…ass selected is changed.
textOuput(ns("selection_textUI"))
…la classification en arrière plan.
lvaudor
reviewed
Jan 5, 2026
Collaborator
There was a problem hiding this comment.
est-ce que shinycssloaders est bien une dépendance? sinon modifier le namespace pour importer juste fonction withSpinner
Collaborator
There was a problem hiding this comment.
même remarque pour bsicons::bs_icon
lvaudor
requested changes
Jan 5, 2026
Collaborator
lvaudor
left a comment
lvaudor
left a comment
There was a problem hiding this comment.
vérifier que les fonctions jamais utilisées jusqu'à présent seront bien accessibles sur le serveur (s'inspirer des importFrom du fichier Namespace). Elles sont accessibles localement car le package a été installé à un moment ou à un autre mais c'est un peu dangereux de pas les importer explicitement pour le déploiement distant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les modifs UI