Replaced memberaudit with corptools#95
Replaced memberaudit with corptools#95HueHue-dev wants to merge 2 commits intoEVE-University:mainfrom
Conversation
| "portrait_url": eve_char.portrait_url(64), | ||
| "character": macharacter, | ||
| "is_shared": macharacter.is_shared, | ||
| "has_skills": Skill.objects.filter(character=ca_character).exists(), |
There was a problem hiding this comment.
Thats i think the most "breaking" change. Because there is no is_shared for corptools i had to find something different. I could use is_active flag. That the character cant be yellow in character audit.
Since the skills is the only relevent part of the character for this app, i thought that would be fine.
There was a problem hiding this comment.
If corptools doesn't have a "share" flag for members, then I assume that means it's always shared and nothing here is needed - which means we probably don't need this at all yeah?
There was a problem hiding this comment.
As far as i understand the character is always shared in corptools. So i could remove this flag. That would be an easy change.
If we assume that the data is synced then this wouldnt cause any issues.
| os.chdir(os.path.normpath(os.path.join(os.path.abspath(__file__), os.pardir))) | ||
|
|
||
| install_requires = ["allianceauth", "aa-memberaudit"] | ||
| install_requires = ["allianceauth", "aa-memberaudit", "corptools"] |
There was a problem hiding this comment.
If we currently have all migrations migrated on the live system, i can commit the change that remove aa-memberaudit. if not we probably need aa-memberaudit for the migrations and after that we can remove memberaudit.
2 participants
No description provided.