docs(design): fix four factual errors in layout page#213
Open
ETBlue wants to merge 2 commits into
Open
Conversation
- remove max-w-md row (only appears in Storybook files, not production code) - fix max-w-sm description: confirmation dialogs → onboarding panels - fix max-w-lg description: wider dialogs → default dialog width (Dialog/AlertDialog base) - remove false claim about Tailwind container utility (not used in production code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying player1inventory-design with
|
| Latest commit: |
35a4e49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c9854fd.player1inventory-design.pages.dev |
| Branch Preview URL: | https://docs-design-guide-layout.player1inventory-design.pages.dev |
Deploying player1inventory-storybook with
|
| Latest commit: |
35a4e49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c24e9f7.player1inventory-storybook.pages.dev |
| Branch Preview URL: | https://docs-design-guide-layout.player1inventory-storybook.pages.dev |
Deploying player1inventory with
|
| Latest commit: |
35a4e49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87d83042.player1inventory.pages.dev |
| Branch Preview URL: | https://docs-design-guide-layout.player1inventory.pages.dev |
…t page - add Global shell section documenting Layout.tsx structure with mobile/desktop ASCII diagrams (bottom nav vs sidebar at lg: breakpoint) - expand Page layout pattern → Page layout patterns covering all three patterns: toolbar+scrollable list (h-[100cqh]), fullscreen toolbar+list (h-screen), and padded form page (min-h-[100cqh]) - clarify why h-[100cqh] vs h-screen are used in different contexts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-w-mdrow — only appears in Storybook files, never in production app codemax-w-smdescription: "Narrow confirmation dialogs" → "Onboarding panels and narrow content sections" (actual usage:TemplateOverview,OnboardingWelcome)max-w-lgdescription: "Wider dialogs" → "Default dialog width (Dialog and AlertDialog base)" (it's baked into the shadcn base classes, not a wider override)containercentering utility is used — it doesn't appear in any production source fileAll corrections verified by grepping the full
apps/web/srctree.Test Plan
dialog.tsx,alert-dialog.tsx,OnboardingWelcome.tsx,TemplateOverview.tsxmax-w-mdis absent from non-story production filescontainerutility class is absent from non-test production files