Custom runoff grid and runoff to ocean mapping #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to specify a custom runoff grid. This includes changes to the grid options, relational constraints, and the grid stages. The custom runoff grid stage is added to the stage pipeline, right after the custom lnd grid stage.
Previously, _process_domain_constraints generated the disjunction of compset and not_compset constraints read in from ccs_config xml files, but we really want the conjunction of not_compset constraints alongside the disjjunction of compset constraints. This commit achieves that. Also made a minor change in custom runoff grid relational specification.
in which case, the current stage skips all (guarded) children and backtracks.
CHanges include: - New runoff to ocean mapping flag and parameters. - Runoff mapping generator widget - Relational constraints - New guarded mapping stage following runoff stage (only activates if mapping is necessary. - If a standard mapping file is found between the selected runoff and ocean grids, the user has the option to use that standard map. - xml changes for mapping files.
alperaltuntas
force-pushed
the
rof_mapping_fixes
branch
from
80d683d to
34a9c1b
Compare
manishvenu
approved these changes
Dec 11, 2025
Collaborator
manishvenu
left a comment
manishvenu
left a comment
There was a problem hiding this comment.
This all works for me, I did get a environment conflict early on, but it disappeared at some point, and I'm not sure why.
I don't understand the ProConPy stuff, but the runoff stage, widget, and processing code makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in major changes for introducing runoff to ocean mapping capability: