-
Notifications
You must be signed in to change notification settings - Fork 36
ISSUE-110 Add additional types of variables to repr.ttl #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lewismc
wants to merge
5
commits into
ESIPFed:master
Choose a base branch
from
lewismc:ISSUE-110
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0c76904
ISSUE-110 Add additional types of variables to repr.ttl
lewismc 1f859ca
ISSUE-110 Add additional types of variables to repr.ttl
lewismc 2d1b953
ISSUE-110 Add additional types of variables to repr.ttl
lewismc f29f753
ISSUE-110 Add additional types of variables to repr.ttl
lewismc d87c470
ISSUE-110 Add additional types of variables to repr.ttl
lewismc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have to review the whole SWEET approach in general, but at least in this case, it seems to me that
repr:1D,repr:2Dandrepr:3Dshould be instances and not classes themselves: you wouldn't be creating instances ofrepr:1Dfor example.Perhaps something like this would be more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First a pragmatic question: would this affect any existing infrastructure that uses sweet and hardcodes certain assumptions about everything being classes, and subClassOf being the main linking predicate? For example, would this cause 1D to drop out of some ontology browser displays?
But I think we also need a definition of 1D and some use cases showing how it gets used. This is where an upper ontology can help. While I think BFO can be a little abstruse at times, it does provide a framework for distinguishing things like variables vs projections in space etc. Going along with this, I think 1D is too short a name for a class, because I don't know from the name what it is. Is it literally the value for a unit "dimension" or can it be used for a 1D entity (e.g a conceptual line between Glasgow and Edinburgh)...?