Skip to content

Fix fates paramgen in tests#4024

Open
mvdebolskiy wants to merge 12 commits into
ESCOMP:b4b-devfrom
mvdebolskiy:fix-fates-paramgen-in-tests
Open

Fix fates paramgen in tests#4024
mvdebolskiy wants to merge 12 commits into
ESCOMP:b4b-devfrom
mvdebolskiy:fix-fates-paramgen-in-tests

Conversation

@mvdebolskiy
Copy link
Copy Markdown
Contributor

@mvdebolskiy mvdebolskiy commented May 15, 2026

Description of changes

Removes FatesSetupParamBuild from some fates tests that need to have fates_paramfile changes. Since we do not need to use ncgen anymore. Also change $SRCROOT in those tests to COMP_ROOT_DIR_LND to be able to run these tests in the coupled model checkout (or in CISM-standalone f.e., or in CAM-standalone).

Specific notes

Contributors other than yourself, if any:

  • (Replace this text and add more list items as needed)

CTSM issues resolved or otherwise addressed, if any:

  • (Replace this text, including GitHub issue #, and add more list items as needed)

Resolves #3989

Any user interface changes (namelist or namelist defaults changes)?
No
Testing planned or performed, if any:

  • aux_clm with -n
  • fates with -n
    No diffs with ctsm5.4.039 namelists.
    Checked fates_paramfile in the CASEROOT to see if changes are correctly applied. They are

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. See testlists above
  • This either (a) does not change answers,
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
  • This PR either (a) does not create a need to update the documentation

@mvdebolskiy mvdebolskiy requested a review from samsrabin May 15, 2026 13:58
@mvdebolskiy mvdebolskiy force-pushed the fix-fates-paramgen-in-tests branch from 3e780d6 to 0daf650 Compare May 15, 2026 14:07
@mvdebolskiy mvdebolskiy changed the base branch from b4b-dev to master May 15, 2026 14:09
@mvdebolskiy mvdebolskiy changed the base branch from master to b4b-dev May 15, 2026 14:09
@samsrabin
Copy link
Copy Markdown
Member

@mvdebolskiy Would you mind bringing this up-to-date with ctsm5.4.041 before I review? It looks like there are a couple of conflicts you'll need to resolve. Thanks!

@mvdebolskiy
Copy link
Copy Markdown
Contributor Author

@samsrabin resolved.

Copy link
Copy Markdown
Member

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you need one of us to do the testing?

@mvdebolskiy
Copy link
Copy Markdown
Contributor Author

@samsrabin I can run the tests which this PR touches, If you give me the --baseline-root on derecho. But probably tomorrow. I've tested it before by running the nprt2 testmod and TwoStream on betzy and also doing namelist only on aux_clm on derecho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants