Fix fates paramgen in tests#4024
Open
mvdebolskiy wants to merge 12 commits into
Open
Conversation
3e780d6 to
0daf650
Compare
Member
|
@mvdebolskiy Would you mind bringing this up-to-date with ctsm5.4.041 before I review? It looks like there are a couple of conflicts you'll need to resolve. Thanks! |
Contributor
Author
|
@samsrabin resolved. |
somehow
samsrabin
approved these changes
May 22, 2026
Member
samsrabin
left a comment
There was a problem hiding this comment.
Looks good! Did you need one of us to do the testing?
Contributor
Author
|
@samsrabin I can run the tests which this PR touches, If you give me the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes
FatesSetupParamBuildfrom some fates tests that need to have fates_paramfile changes. Since we do not need to usencgenanymore. Also change$SRCROOTin those tests toCOMP_ROOT_DIR_LNDto be able to run these tests in the coupled model checkout (or in CISM-standalone f.e., or in CAM-standalone).Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Resolves #3989
Any user interface changes (namelist or namelist defaults changes)?
No
Testing planned or performed, if any:
-n-nNo diffs with ctsm5.4.039 namelists.
Checked fates_paramfile in the CASEROOT to see if changes are correctly applied. They are
Requirements before merge: