Fix baseline comparison issue and merge latest CICE main changes into ESCOMP sealevelponds#37
Merged
dabail10 merged 6 commits intoESCOMP:sealevelpondsfrom Jan 9, 2025
Conversation
…3.2.0 (CICE-Consortium#1000) Update Icepack to #fa56e7e387b1, needed for cce/17.0.0 Cleaned up some trailing blanks.
This is a two-line change in ice_flux.F90 (scale_fluxes) to check for the condition where aice > 0, but flwout > -puny (effectively zero). This means the cell was ice free at the beginning of the step, but non-zero at the end. It sets the outgoing longwave to the open ocean value based on the freezing temperature. This is bfb, but will change the history output of flwup and flwup_ai. Test results are coming.
… bfb (CICE-Consortium#1002) Update Icepack to #43ead56380b, hocn and flushing velocity issue, not bfb. See CICE-Consortium/Icepack#504
…vlponds, fails baseline comparison test
…son test with main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Fix the initialization of tscale_pnd_drain and merge latest CICE main branch changes so that baseline comparison tests pass.
@davidclemenssewall
@dabail10
Passed baseline comparison test for run1day on conda linux. STILL NEEDS COMPARISON WITH CICE SUITE.
Sealevelponds branch was failing baseline comparison tests. This issue was found to be caused by the initialization of the tscale_pnd_drain parameter and has been fixed. Additionally, while fixing this issue an issue related to how sealevelponds was being initialized was discovered and fixed for the standalone driver. Those changes will need to be propagated to the other drivers. Regression tests have only been completed vs. a run1day test and so the full suite still needs to be run.