Skip to content

Add glofas#351

Open
mnlevy1981 wants to merge 8 commits intoESCOMP:mainfrom
mnlevy1981:add_glofas
Open

Add glofas#351
mnlevy1981 wants to merge 8 commits intoESCOMP:mainfrom
mnlevy1981:add_glofas

Conversation

@mnlevy1981
Copy link
Copy Markdown
Contributor

Description of changes

A companion to ESMCI/ccs_config_cesm#255, this PR is necessary to support a new runoff data set

Specific notes

Contributors other than yourself, if any: @manishvenu

CDEPS Issues Fixed (include github issue #): N/A

Are there dependencies on other component PRs (if so list): CESM will also need ESMCI/ccs_config_cesm#255

Are changes expected to change answers (bfb, different to roundoff, more substantial): this should be bfb in all tested configurations; we are adding a new data stream, but not altering any existing ones.

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): This will be thoroughly tested before being taken out of draft mode

Hashes used for testing:

mnlevy1981 and others added 5 commits August 27, 2024 16:50
Was based on cesm2_3_alpha17f, but diffs applied to cesm3_0_alpha03a
I also removed a rof.globas entry that was actually on the wrong grid
@jedwards4b
Copy link
Copy Markdown
Contributor

@mnlevy1981 Hi Mike - what is the status of this PR?

@mnlevy1981
Copy link
Copy Markdown
Contributor Author

I definitely need to move some files around for the companion PR in ccs_config_cesm; I'll do that today and also check in with @manishvenu to see if any of the data sets have changed or if this is ready to go. Thanks for the reminder, this had fallen off my radar.

@mnlevy1981
Copy link
Copy Markdown
Contributor Author

@manishvenu this should come out of draft and be marked ready for review, right? Or does ESMCI/ccs_config_cesm#255 need to be finished first?

@manishvenu
Copy link
Copy Markdown

@manishvenu this should come out of draft and be marked ready for review, right? Or does ESMCI/ccs_config_cesm#255 need to be finished first?

Hey @mnlevy1981, I think this one can be done first? I'm not an expert on what order it needs to come in, but this one seems right.

I think it's ready for review, but will post a new GLOFAS path tomorrow.

@manishvenu
Copy link
Copy Markdown

manishvenu commented May 1, 2026

Hey @mnlevy1981,

I moved the GLOFAS files to a similar place to the JRA runoff files, here is the new paths and command:

Files: $DIN_LOC_ROOT/ocn/glofas/v4/GLOFAS.v4.dis24.%y.nc
MeshFIle: $DIN_LOC_ROOT/ocn/glofas/v4/metadata/GLOFAS.v4.ESMFmesh.nc

The one question I had is that all the runoff meshfiles are in dlnd. Do we want to move GLOFAS meshfile there?

Thanks,
Manish V.

@mnlevy1981
Copy link
Copy Markdown
Contributor Author

The one question I had is that all the runoff meshfiles are in dlnd. Do we want to move GLOFAS meshfile there?

Yeah, I think we want it to be named lnd/dlnd7/GLOFAS/GLOFAS.v4.dis24.ESMFmesh_20260501.nc (and we need to drop the NaN _FillValue attributes)

mnlevy1981 added 2 commits May 1, 2026 13:54
The glofas mesh file is now in lnd/dlnd7, and the runoff data files were moved
to ocn/glofas
@manishvenu
Copy link
Copy Markdown

manishvenu commented May 1, 2026

Hey @mnlevy1981,

I don't have permissions to add the ESMF Mesh here. I've generated the mesh here: /glade/campaign/cesm/cesmdata/cseg/inputdata/ocn/glofas/v4/metadata/GLOFAS.v4.dis24.ESMFmesh_20260501.nc

@mnlevy1981 mnlevy1981 marked this pull request as ready for review May 1, 2026 22:19
@mnlevy1981
Copy link
Copy Markdown
Contributor Author

Hey @mnlevy1981,

I don't have permissions to add the ESMF Mesh here. I've generated the mesh here: /glade/campaign/cesm/cesmdata/cseg/inputdata/ocn/glofas/v4/metadata/GLOFAS.v4.dis24.ESMFmesh_20260501.nc

I just copied it to the correct directory, and we can run rimport next week after testing everything in a fresh sandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants