Conversation
|
Thanks for the PR! Since this is aimed as a executable script, can you move this commit to under the earthcode/cli please |
| "pydantic>=2.12.5,<3", | ||
| "requests>=2.32.5,<3", | ||
| "tokenizers>=0.22.2,<1", | ||
| "PyYAML>=6.0.3", |
There was a problem hiding this comment.
Can you please pin down the highest version of PyYaml please
| onnxruntime = ">=1.24.1,<2" | ||
| platformdirs = ">=4.5.0,<5" | ||
| tokenizers = ">=0.22.2,<1" | ||
| PyYAML = ">=6.0.3" |
There was a problem hiding this comment.
Can you please pin down the highest version of PyYaml please
There was a problem hiding this comment.
you also need to update pixi lock file so the environment is consistent (or else tests fail/etc)
There was a problem hiding this comment.
I see that the pixi.lock file is meant to be updated automatically with the "pixi install" cmd, but as you know I can't do this on my work laptop due to enterprise restrictions.
| workflow_record = create_workflow_record(workflow_metadata) | ||
|
|
||
| # save this file and copy it to the catalog/workflows/{workflow-id}/record.json | ||
| with open(os.path.join(target, 'workflow_record.json'), 'w') as f: |
There was a problem hiding this comment.
I'm not sure how you plan to use it internally but this will fail the actual validation since it's missing links from the workflow catalog to the generated file. So this will fail validation generally just by itself.
You can save the workflow record using earthcode.git.add.save_workflow_record_to_osc this will automatically handle the required links.
There are similar functions for projects, experiments, products, etc....
note that you'll need clone of the osc repo for this!
…ation - and making corrections to yaml templates
|
thanks Claudio, I've added a minor refactor;
please see if the test is a realistic integration test of how you might call the function. If yes, then the generated stac items should also pass the open-science-catalog-validation when you commit them to https://opensciencedata.esa.int/catalog. |
…and be included in builds
2 participants
Added YAML Template Generation
Added Stac Generation from YAML Templates using the functions already present in the library.
Made Template and Stac generation commands importable (for Jupyter Notebooks) and executable from CLI in Local
Added tests
I will update the documentation, guide and examples after this MR.