Return HTTP 413 if response exceeds configured MAXIMUM_BYTES_RETURNED#46
Open
nuwanwre wants to merge 5 commits intoEIDA:masterfrom
Open
Return HTTP 413 if response exceeds configured MAXIMUM_BYTES_RETURNED#46nuwanwre wants to merge 5 commits intoEIDA:masterfrom
MAXIMUM_BYTES_RETURNED#46nuwanwre wants to merge 5 commits intoEIDA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #39 and #43 where responses were abruptly cut-off.
Changes proposed here does 2 things,
Gets rid of streaming when configured
MAXIMUM_BYTES_RETURNED > 0.This enables the service to build the response before sending a HTTP response to the consumer. Previous implementation starts streaming data right away starting with a HTTP 200 response, and it's not possible to return HTTP 413 later on.
Note: This could result in memory spikes.
MAXIMUM_BYTES_RETURNED = 0will still allow streaming and avoid memory spikes.Note: Please refer to MongoDB limitations on open cursor and maximum document size that can be returned.
Example query (with
MAXIMUM_BYTES_RETURNED = 10e3for demonstration),Other explored solutions