Conversation
Contributor
|
I would suggest a slight modification to not count tests towards LOC, otherwise that discourages testing which I doubt is ideal. |
11 tasks
Co-authored-by: Markus Unterwaditzer <markus-tarpit+git@unterwaditzer.net>
untitaker
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lately we have received a large influx of pull requests, which is great, we want #868! However, some of these pull requests are quite large which make them difficult if not impossible to actually do code review on. I'm aware that some of you like to use AI coding agents and I'm not against that if you can explain / understand all your code, and you write the documentation yourself. But AI coding agents tend to cause people to make very verbose commits of 1000 or more lines, which are just impossible to review.
My proposal: going forward we limit pull requests to no more than 400 lines of code, if your features requires more lines than that you will have to break it up into smaller chunks. Any pull request longer than 400 lines (at our discretion, I'm not going to throw away my judgement just because a good pull request happens to be 401 lines) will be closed and the submitter asked to resubmit. Why 400? According to this study a reviewers ability to find bad code diminishes significantly after 400 lines of code. This is consistent with my lived experience as well. I'm would like to discuss this as a community and come to a decision in about a week unless everyone instantly agrees (though anyone with open PRs over 400 LOC would have my appreciation if they would resubmit.)