Add new bot: cancel command
#359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| # Update job status table | ||
| dt = datetime.now(timezone.utc) | ||
| update = f"\n|{dt.strftime("%b %d %X %Z %Y")}|finished|job id `{job_id}` was cancelled|" |
There was a problem hiding this comment.
SyntaxError: invalid syntax
missing whitespace around modulo operator
missing whitespace around operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #190
The command allows for cancelling multiple jobs in one command, e.g.
bot: cancel jobid:1 jobid:2. The status table of each job is updated to show that the job was cancelled. A build job can only be cancelled by the job owner (the one who submitted it). This is done by adding the name of the job owner to the job metadata file, and checking that the name matches before cancelling the job.A new setting is required for the command, 'cancel_command' in the '[buildenv]' section.
One small issue at the moment is that jobs that are known by the job manager get
UNKNOWNstatus when they are cancelled, but I guess that can be easily ignored and fixed in another PR if needed.I have (hopefully) updated the documentation and tests where necessary, although I haven't added any new tests.
First PR, sorry for the single huge commit 😅 Any feedback would be appreciated 🙂