Localize Core Messages#2664
Draft
GLWine wants to merge 2 commits into
Draft
Conversation
Import l10n translations earlier and replace hard-coded popup/notification strings with tr.tl(...) calls using CR/LF placeholders. Standardize message formatting across journal-lock, process-already-running, update notifications, provider reset, plugin errors and critical error dialogs, remove manual \"replace('\\n','\n').replace('\\r','\r')\" post-processing and the duplicate l10n import. This consolidates i18n handling and normalizes linebreak formatting for localized messages.
Update L10n/en.template to replace literal CRLF sequences in several localized popup strings with {LF}{CR} placeholders for consistent newline handling. Also add two new localization entries for journal-lock and duplicate-process startup warnings and adjust plugin, provider-reset, and update-track messages to use the new placeholders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements localization for core application messages in EDMarketConnector.py, enabling translation of critical user-facing strings such as error popups, notifications, and startup warnings. The changes standardize message formatting and consolidate i18n handling across the application.
This work is a parallel integration to PR #2617, which localized the authentication success message. Together, these changes expand localization coverage to additional core UI elements while maintaining consistency with the established patterns.
Key Changes:
tr.tl()calls for proper translation support.{LF}{CR}placeholders in localization strings to handle line breaks consistently, replacing manualreplace('\\n','\n').replace('\\r','\r')post-processing.Files Modified:
Benefits:
This PR targets the
developbranch and maintains backward compatibility while enhancing internationalization support. All changes are based on the existing l10n infrastructure and follow the project's translation patterns established in PR #2617.