Open
Conversation
商品レビューのCSVダウンロード時に、誤って商品一覧の検索条件セッションキーを参照していた問題を修正 - 修正前: 'eccube.admin.product.search' - 修正後: 'product_review.admin.product_review.search' これにより、商品レビュー一覧で絞り込んだ検索条件でCSVダウンロードが正しく動作するようになる Fixes EC-CUBE#96
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the CSV download functionality in the product review admin was incorrectly referencing the session key for product search instead of product review search. The fix ensures that when downloading a CSV file, the correct search filters from the product review list are applied.
Changes:
- Corrected session key in the
download()method from'eccube.admin.product.search'to'product_review.admin.product_review.search'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
商品レビューのCSVダウンロード時に、誤って商品一覧の検索条件セッションキーを参照していた問題を修正
これにより、商品レビュー一覧で絞り込んだ検索条件でCSVダウンロードが正しく動作するようになる
Fixes #96