[Feat] review v2 logevent #429
Conversation
Summary of ChangesHello @HI-JIN2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on integrating robust event logging into the 'review v2' feature set. The primary goal is to gain deeper insights into user behavior within the review flow, from viewing review lists to writing and modifying reviews. By tracking screen views and detailed submission metrics, the team can better understand feature engagement and optimize the user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| REVIEW_V2_VIEW("REV_001001_V2"), | ||
| REVIEW_V3_VIEW("REV_001000_V3"), // todo 사진 모아보기가 있는 v3 버전 | ||
|
|
||
| REVIEW_V2_WRITE("REV_001001_V2"), |
There was a problem hiding this comment.
REVIEW_V2_VIEW와 REVIEW_V2_WRITE의 화면 ID 값이 "REV_001001_V2"로 동일합니다. 화면 구분을 위해 각 화면 ID는 고유한 값을 가져야 합니다. 이 값이 중복되면 애널리틱스에서 두 화면을 구분할 수 없어 데이터 정확성에 심각한 문제가 발생합니다. REVIEW_V2_VIEW의 값을 다른 고유한 값으로 수정하는 것을 제안합니다. 예를 들어, 삭제된 REVIEW_V2_1의 값이었던 "REV_001000_V2"를 사용할 수 있습니다.
| REVIEW_V2_VIEW("REV_001001_V2"), | |
| REVIEW_V3_VIEW("REV_001000_V3"), // todo 사진 모아보기가 있는 v3 버전 | |
| REVIEW_V2_WRITE("REV_001001_V2"), | |
| REVIEW_V2_VIEW("REV_001000_V2"), | |
| REVIEW_V3_VIEW("REV_001000_V3"), // todo 사진 모아보기가 있는 v3 버전 | |
| REVIEW_V2_WRITE("REV_001001_V2"), |
| onImageDelete = { viewModel.setSelectedImage(null) }, | ||
| onSubmit = { viewModel.postReview(menuType, id, context) } | ||
| onSubmit = { | ||
| EventLogger.writeReview() |
There was a problem hiding this comment.
EventLogger.writeReview() 함수는 v1 리뷰 작성 시작 이벤트(WRITE_REVIEW_V1)를 로깅하도록 구현되어 있습니다. 현재 v2 리뷰 기능에 대한 로깅을 추가하고 있으므로, v1 이벤트를 사용하는 것은 적절하지 않습니다. EventLogger에 writeReviewV2와 같은 새로운 함수를 추가하여 v2에 맞는 이벤트를 로깅하거나, 이 이벤트의 목적을 다시 확인해주세요. EventLogger.kt의 writeReview 함수에 //todo v2로 바꿀시 v1 제거 라는 주석이 있는 것으로 보아 수정이 필요한 부분으로 보입니다.
Summary
Describe your changes
Issue
To reviewers