Add support for spack v1.0.0#281
Closed
andrewdnolan wants to merge 13 commits intoE3SM-Project:mainfrom
Closed
Conversation
andrewdnolan
added
enhancement
andrewdnolan
force-pushed
the
spack-v1.0.0
branch
4 times, most recently
from
72bdea3 to
b479abb
Compare
andrewdnolan
force-pushed
the
spack-v1.0.0
branch
from
edf1402 to
be12e85
Compare
Currently only testing on chrysalis with gnu compiler and openmpi.
Got a: ``` No module named 'spack_repo.builtin.packages.libftdi' ``` error when I tried to use `spack-packages`as the name. Error no longer occurs when name is `builtin`.
hdf5, netcdf-c, netcdf-fortran and pnetcdf
andrewdnolan
force-pushed
the
spack-v1.0.0
branch
from
be12e85 to
e843e43
Compare
Collaborator
|
@andrewdnolan, could we close this for now and open a fresh PR when the time comes? I think things have changed too much for this branch to be a good basis for our next attempt at this, though it is a good point of references. |
Collaborator
Author
|
Agreed. Trying to merge/rebase those would be a nightmare. This might be helpful to reference when we trying again, but no sense in leaving this open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Testingcomment, if appropriate, in the PR documents testing used to verify the changes