DYN-9151: Show trust warning popup before Open/Insert command execution#17104
Draft
Copilot wants to merge 3 commits into
Draft
DYN-9151: Show trust warning popup before Open/Insert command execution#17104Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
5 tasks
Agent-Logs-Url: https://github.com/DynamoDS/Dynamo/sessions/6a0b0707-437a-4932-99a5-642be0cb85b4 Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
…ings Agent-Logs-Url: https://github.com/DynamoDS/Dynamo/sessions/6a0b0707-437a-4932-99a5-642be0cb85b4 Co-authored-by: johnpierson <15744724+johnpierson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix trust warning popup delay for large graph opening
DYN-9151: Show trust warning popup before Open/Insert command execution
May 12, 2026
| var insertMethod = typeof(DynamoViewModel).GetMethod("Insert", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| Assert.NotNull(insertMethod); | ||
|
|
||
| var insertPath = Path.Combine(GetTestDirectory(ExecutingDirectory), @"core\CustomNodes\TestAdd.dyn"); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Opening a
.dynfrom an untrusted location showed the trust popup only after synchronous graph load completed, which made the warning appear delayed on large graphs. This change moves popup activation ahead of heavy open/insert work and reconciles state after load.Behavioral fix: pre-load popup activation in
DynamoViewModel.OpenandInsertdisplayTrustWarningas before (including.dyfexclusion).FileTrustViewModelpopup state before executingOpenFileCommand/InsertFileCommand.RunSettings.ForceBlockRun.Post-load reconciliation
ShowHideFileTrustWarningIfCurrentWorkspaceTrusted()after command execution (only when warning was pre-shown) to resolve cases where trust state changed during load (e.g., location became trusted or warnings disabled).Failure-path cleanup
ResetTrustWarningStateIfNeeded(...)to clear popup/block-run state if open/insert throws after pre-showing the warning.Regression coverage
DynamoViewTests:WhenOpeningWorkspaceThenTrustWarningIsShownBeforeCommandWhenInsertingWorkspaceThenTrustWarningIsShownBeforeCommandtrueat command start (Model.CommandStarting) for the corresponding command type.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
npm.autodesk.com/usr/bin/pwsh pwsh -ExecutionPolicy Bypass -File /home/REDACTED/work/Dynamo/Dynamo/src/setnpmreg.ps1(dns block)/usr/bin/pwsh pwsh -ExecutionPolicy ByPass -Command & '/home/REDACTED/work/Dynamo/Dynamo/src/setnpmreg.ps1'(dns block)If you need me to access, download, or install something from one of these locations, you can either: