DYN-10491: Fix template open for legacy XML .dyn files#17102
Open
Chloepeg wants to merge 1 commit into
Open
Conversation
OpenTemplateFromPath now matches OpenFileFromPath: try JSON, then fall back to XML when JSON parsing fails. OpenXmlFileFromPath accepts an optional isTemplate flag so XML graphs opened from File > New > From Template set WorkspaceModel.IsTemplate like JSON template opens.
github-actions
Bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10491
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-10491 https://jira.autodesk.com/browse/DYN-10491 The changes in the code aim to fix misleading "corrupted file" error for valid old XML workspaces opened from File- New - From template
This issue was discovered while testing the new workflow ( File- New - From template https://jira.autodesk.com/browse/DYN-10228 ) But this behaviour already existed in previous File - Open -Template workflow
Changes :
OpenTemplateFromPath now matches OpenFileFromPath: try JSON, then fall back to XML when JSON parsing fails. OpenXmlFileFromPath accepts an optional isTemplate flag so XML graphs opened from File > New > From Template set WorkspaceModel.IsTemplate like JSON template opens.
Issue :
Fix :
Declarations
Check these if you believe they are true
Release Notes
Align OpenTemplateFromPath with OpenFileFromPath JSON-then-XML load.
Set IsTemplate on XML-opened workspaces for the template flow.
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@johnpierson
@jnealb