Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the dynamo-dotnet-expert agent skill to be a slimmer navigation hub and moves detailed guidance into modular reference documents, aligning with the repo’s skill modularization pattern.
Changes:
- Split detailed C#/.NET guidance into
assets/csharp-patterns.mdand PublicAPI workflow guidance intoassets/publicapi-guide.md. - Added
references/quality-checklist.mdconsolidating “quality gates” (anti-patterns, security rules, file constraints, PR checklist). - Updated
SKILL.mdto add a workflow section, a quick decision guide, and cross-links to related skills.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .agents/skills/dynamo-dotnet-expert/references/quality-checklist.md | Adds a consolidated checklist for common pitfalls, security rules, constraints, and PR hygiene. |
| .agents/skills/dynamo-dotnet-expert/assets/publicapi-guide.md | Documents PublicAPI tracking workflow and breaking-change process for Dynamo projects. |
| .agents/skills/dynamo-dotnet-expert/assets/csharp-patterns.md | Adds a centralized reference for modern C# patterns, type design, async/perf guidance, and WPF/UI notes. |
| .agents/skills/dynamo-dotnet-expert/SKILL.md | Converts the skill doc into a workflow + navigation entrypoint with links to the new references. |
Comment on lines
+94
to
+97
| Then add to `src/DynamoCore/PublicAPI.Unshipped.txt`: | ||
| ``` | ||
| Dynamo.Core.DynamoModel.GetWorkspaceName(string) -> string? | ||
| ``` |
Comment on lines
+9
to
+10
| - Format: `namespace.ClassName.MemberName -> ReturnType` | ||
| - Example: `Dynamo.Core.DynamoModel.GetWorkspaceName(string) -> string?` |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor the dynamo-dotnet-expert agent skill to improve navigability, coverage, and alignment with the
dynamo-skill-writer modular pattern.
Key changes:
assets/publicapi-guide.md (PublicAPI workflow, breaking change process)
checklist from AGENTS.md
Added WPF/UI guidance for DynamoCoreWpf work (MVVM, dispatcher, commands) — previously absentDeclarations
Check these if you believe they are true
Release Notes
N/A
Reviewers
@kalunkuo @avidit @DynamoDS/eidos
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of