DYN-8951: As a standards manager, I want to be able to customize the OOTB node group styles#16969
Open
ivaylo-matov wants to merge 16 commits intoDynamoDS:masterfrom
Open
DYN-8951: As a standards manager, I want to be able to customize the OOTB node group styles#16969ivaylo-matov wants to merge 16 commits intoDynamoDS:masterfrom
ivaylo-matov wants to merge 16 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8951
Contributor
There was a problem hiding this comment.
Pull request overview
Enables customization/removal of out-of-the-box (default) node group styles and adds a “Reset Styles” flow to restore Dynamo’s default group styles, including UI and context-menu behavior updates.
Changes:
- Updates Preferences UI to allow editing/removing default group styles and adds a Reset Styles button with localized strings.
- Adjusts group-style persistence/restore logic (avoid recreating defaults when list is empty; create defaults only for brand-new settings).
- Improves group context-menu behavior (disable Group Style submenu when empty; only show separator when needed) and adds WPF tests.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DynamoCoreWpfTests/GroupStylesTests.cs | Adds unit/UI tests for reset behavior and disabled submenu behavior. |
| src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml | Enables editing/removal UI for default styles and adds Reset Styles button + tooltip. |
| src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs | Implements Reset Styles click handler + analytics event. |
| src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs | Adds reset capability flags/logic and default-style matching helper. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml.cs | Allows disabling submenu item and prevents hover-open when disabled. |
| src/DynamoCoreWpf/ViewModels/Core/AnnotationViewModel.cs | Adds helper for whether Group Style submenu should be enabled; separator logic change. |
| src/DynamoCore/Configuration/GroupStyleItem.cs | Adds cloning helper to restore clean default style items. |
| src/DynamoCore/Configuration/PreferenceSettings.cs | Ensures group styles list is non-null on load and de-dupes entries. |
| src/DynamoCore/Models/DynamoModel.cs | Seeds default group styles only for brand-new preference settings. |
| src/DynamoCoreWpf/Properties/Resources.resx | Adds localized Reset Styles button text + tooltip. |
| src/DynamoCoreWpf/Properties/Resources.en-US.resx | Adds en-US Reset Styles button text + tooltip. |
| src/DynamoCoreWpf/Properties/Resources.Designer.cs | Regenerated resource accessors for new strings. |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Tracks new public resource properties in API surface. |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
on sonarQube's new issue - |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-8951 as well as DYN-9872. The proposed changes allow users to customize or delete OOTB node group styles, instead of being limited to adding new custom styles.
Changes:
Reset Stylesbutton with tooltip and visibility bound to reset availabilityCanResetGroupStylesandResetCustomGroupStylesinPreferencesViewModelGroupStyleItem.CloneDefaultGroupStyleItems()to restore clean defaultsPreferencesViewModelno longer recreates default styles when the list is emptyDynamoModelcreates default styles only for brand-new settingsGroup Stylesubmenu is disabled when no group styles existDeclarations
Check these if you believe they are true
Release Notes
Users can now edit and remove default node group styles, and reset all group styles back to defaults from Preferences.
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@johnpierson