Skip to content

DYN-10266: Disallow DYF Files as Templates in File Open Template Dialog#16954

Open
ivaylo-matov wants to merge 2 commits intoDynamoDS:masterfrom
ivaylo-matov:DYN-10266-Disallow-DYF-files-as-templates
Open

DYN-10266: Disallow DYF Files as Templates in File Open Template Dialog#16954
ivaylo-matov wants to merge 2 commits intoDynamoDS:masterfrom
ivaylo-matov:DYN-10266-Disallow-DYF-files-as-templates

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-10266. It updates the File -> Open -> Template flow so it behaves as a template-only entry point.

Changes:

  • restricted the template open dialog file filter to .dyn only
  • added a template-specific dialog title resource and wired the template path to use it - "New graph from template"
image

Declarations

Check these if you believe they are true

Release Notes

This PR updates the File -> Open -> Template flow so it behaves as a template-only entry point.

Reviewers

@zeusongit
@DynamoDS/eidos

FYIs

@dnenov
@johnpierson

Copilot AI review requested due to automatic review settings March 11, 2026 17:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10266

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Dynamo’s File → Open → Template flow to behave as a template-only entry point by tightening the open-dialog behavior for templates and introducing a dedicated, localized dialog title.

Changes:

  • Restricts the template open dialog filter to .dyn files.
  • Adds and wires a new localized dialog title resource (“New Graph from Template...”).
  • Updates PublicAPI tracking for the new resource accessor.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs Adjusts file dialog filter and title based on whether the dialog is invoked for templates.
src/DynamoCoreWpf/PublicAPI.Unshipped.txt Records the newly exposed resource accessor in the public API unshipped list.
src/DynamoCoreWpf/Properties/Resources.resx Adds the neutral-culture string for the new template dialog title.
src/DynamoCoreWpf/Properties/Resources.en-US.resx Adds the en-US localized string for the new template dialog title.
src/DynamoCoreWpf/Properties/Resources.Designer.cs Adds the strongly-typed resource property for the new string.
Files not reviewed (1)
  • src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

@sonarqubecloud
Copy link

Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ivaylo-matov - solid work here. The changes look clean and the separation between template and non-template flows is well done. Last thing is to see what is failing on that smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants