Conversation
This reverts commit 0383df8.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| public void PythonEnginePackageDependencyIsCollectedAndSerialized() | ||
| { | ||
| // Load JSON file graph | ||
| string path = Path.Combine(TestDirectory, @"core\packageDependencyTests\PythonDependency.dyn"); |
| Assert.IsEmpty(json[WorkspaceReadConverter.NodeLibraryDependenciesPropString]); | ||
| } | ||
|
|
||
| string packageDirectory = Path.Combine(TestDirectory, @"core\packageDependencyTests\PythonEnginePackage"); |
pinzart90
changed the title
|
@pinzart90 I don't understand from your description if you found what was causing the test failure or not? |
|
@pinzart90 there is a test failure: maybe these tests are interacting, does this test fixture pass locally for you now that you moved the test here? |
|
Updated this branch to run latest job, master should be clear as of now |
|
thanks @QilongTang - @pinzart90 can you take another look at this? What's the next step here. |
|
Looks like the test got moved is passing but |
|
@copilot Fix the following unit test: Error Message |
|
@QilongTang I've opened a new pull request, #16889, to work on those changes. Once the pull request is ready, I'll request review from you. |
Purpose
Issue:
Test
Dynamo.Tests.PackageDependencyTests.PythonEnginePackageDependencyIsCollectedAndSerializedis failing for DynamoCoreService (DaaS)What changed:
Moved the
PythonEnginePackageDependencyIsCollectedAndSerializedtest from DynamoCoreTests to DynamoPythonTests.DynamoCoreService does not use python (yet), so testing python for DaaS is not critical.
Temporary fix on the linux job side https://git.autodesk.com/Dynamo/DynamoSelfServe/commit/1cfa6cc385d19a7a513f5132cce4307580f4f55b
Declarations
Check these if you believe they are true
Release Notes
Moved python test from DynamoCoreTests to DynamoPythonTests
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of