DYN-6409: Disable PM requests with no-network mode

src/DynamoCore/Configuration/ExecutionSession.cs

@@ -26,6 +26,7 @@ public ExecutionSession(Scheduler.UpdateGraphAsyncTask updateTask, DynamoModel m
             parameters[ParameterKeys.LastExecutionDuration] = new TimeSpan(updateTask.ExecutionEndTime.TickCount - updateTask.ExecutionStartTime.TickCount);
             parameters[ParameterKeys.PackagePaths] = pathManager.PackagesDirectories;
             parameters[ParameterKeys.Logger] = model.Logger;
+            parameters[ParameterKeys.NoNetworkMode] = model.NoNetworkMode;
         }
 
         /// <summary>

src/DynamoCore/Models/DynamoModel.cs

@@ -237,7 +237,7 @@ public static string Version
         internal bool IsServiceMode { get; set; }
 
         /// <summary>
-        /// True if Dynamo starts up in offline mode.
+        /// True if Dynamo is used in offline mode.
         /// </summary>
         internal bool NoNetworkMode { get; }
 

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

@@ -2810,12 +2810,12 @@ internal void ShowPackageManager(object parameters)
 
         internal bool CanShowPackageManagerSearch(object parameters)
         {
-            return !model.IsServiceMode;
+            return !model.IsServiceMode && !model.NoNetworkMode;
         }
 
         internal bool CanShowPackageManager(object parameters)
         {
-            return !model.IsServiceMode;
+            return !model.IsServiceMode && !model.NoNetworkMode;
         }
 
         /// <summary>

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

@@ -1346,6 +1346,24 @@ private void AddPythonEnginesOptions()
         /// </summary>
         public TrustedPathViewModel TrustedPathsViewModel { get; set; }
 
+        private bool noNetworkMode;
+
+        /// <summary>
+        /// True if Dynamo is used in offline mode.
+        /// </summary>
+        public bool NoNetworkMode
+        {
+            get => noNetworkMode;
+            private set
+            {
+                if (noNetworkMode != value)
+                {
+                    noNetworkMode = value;
+                    RaisePropertyChanged(nameof(NoNetworkMode));
+                }
+            }
+        }
+
         /// <summary>
         /// Returns a boolean value indicating if the Settings importing was successful or not
         /// </summary>
@@ -1469,6 +1487,8 @@ public PreferencesViewModel(DynamoViewModel dynamoViewModel)
             this.pythonScriptEditorTextOptions = dynamoViewModel.PythonScriptEditorTextOptions;
             this.dynamoViewModel = dynamoViewModel;
 
+            NoNetworkMode = dynamoViewModel.Model.NoNetworkMode;
+
             if (dynamoViewModel.PackageManagerClientViewModel != null)
             {
                 installedPackagesViewModel = new InstalledPackagesViewModel(dynamoViewModel, dynamoViewModel.PackageManagerClientViewModel.PackageManagerExtension.PackageLoader);

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs

@@ -343,7 +343,7 @@ public void PublishCurrentWorkspace(object m)
 
         public bool CanPublishCurrentWorkspace(object m)
         {
-            return DynamoViewModel.Model.CurrentWorkspace is CustomNodeWorkspaceModel && AuthenticationManager.HasAuthProvider;
+            return DynamoViewModel.Model.CurrentWorkspace is CustomNodeWorkspaceModel && AuthenticationManager.HasAuthProvider && !Model.NoNetworkMode;
         }
 
         public void PublishNewPackage(object m)
@@ -363,7 +363,7 @@ public void PublishNewPackage(object m)
 
         public bool CanPublishNewPackage(object m)
         {
-            return AuthenticationManager.HasAuthProvider;
+            return AuthenticationManager.HasAuthProvider && !Model.NoNetworkMode;
         }
 
         public void PublishCustomNode(Function m)
@@ -393,7 +393,7 @@ public void PublishCustomNode(Function m)
 
         public bool CanPublishCustomNode(Function m)
         {
-            return AuthenticationManager.HasAuthProvider && m != null;
+            return AuthenticationManager.HasAuthProvider && m != null && !Model.NoNetworkMode;
         }
 
         public void PublishSelectedNodes(object m)
@@ -453,7 +453,7 @@ public void PublishSelectedNodes(object m)
         public bool CanPublishSelectedNodes(object m)
         {
             return DynamoSelection.Instance.Selection.Count > 0 &&
-                   DynamoSelection.Instance.Selection.All(x => x is Function) && AuthenticationManager.HasAuthProvider; ;
+                   DynamoSelection.Instance.Selection.All(x => x is Function) && AuthenticationManager.HasAuthProvider && !Model.NoNetworkMode;
         }
 
         private void ShowNodePublishInfo()

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml

@@ -14,6 +14,7 @@
         xmlns:fa="clr-namespace:FontAwesome5;assembly=FontAwesome5.Net" 
         xmlns:packagemanager="clr-namespace:Dynamo.Wpf.Views.PackageManager"
         xmlns:trustedpaths="clr-namespace:Dynamo.Wpf.Views"
+        xmlns:converters="clr-namespace:Dynamo.Controls;assembly=DynamoCoreWpf"
         xmlns:wpfControls="clr-namespace:Dynamo.Wpf.Controls"
         d:DataContext="{d:DesignInstance Type=viewModels:PreferencesViewModel}"
         WindowStartupLocation="CenterOwner"
@@ -1949,7 +1950,19 @@
                                     <Hyperlink Click="OnInstalledPackagesHyperlinkClicked"
                                                 Foreground="{StaticResource TextBlockLinkForegroundColor}">
                                         <TextBlock Name="PackageManagerLink"
-                                                    Text="{x:Static p:Resources.InstalledPackagePartialHyperlinkMessage}" />
+                                                    Text="{x:Static p:Resources.InstalledPackagePartialHyperlinkMessage}"
+                                                    IsHitTestVisible="{Binding NoNetworkMode, Converter={StaticResource InverseBooleanConverter}}">
+                                            <TextBlock.Style>
+                                                <Style TargetType="TextBlock">
+                                                    <!--<Setter Property="Foreground" Value="Black" />-->
+                                                    <Style.Triggers>
+                                                        <DataTrigger Binding="{Binding NoNetworkMode}" Value="True">
+                                                            <Setter Property="Foreground" Value="Gray" />
+                                                        </DataTrigger>
+                                                    </Style.Triggers>
+                                                </Style>
+                                            </TextBlock.Style>
+                                        </TextBlock>
                                     </Hyperlink>
                                     <Run>.</Run>        
                                 </TextBlock>

src/DynamoPackages/PackageManagerClient.cs

@@ -49,18 +49,24 @@ public string BaseUrl
             get { return this.client.BaseUrl; }
         }
 
+        internal readonly bool NoNetworkMode;
+
         #endregion
 
-        internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder, string packageUploadDirectory)
+        internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder, string packageUploadDirectory,
+            bool noNetworkMode = false)
         {
             this.packageUploadDirectory = packageUploadDirectory;
             this.uploadBuilder = builder;
             this.client = client;
             this.packageMaintainers = new Dictionary<string, bool>();
+            this.NoNetworkMode = noNetworkMode;
         }
 
         internal bool Upvote(string packageId)
         {
+            if (NoNetworkMode) return false;
+
             return FailFunc.TryExecute(() =>
             {
                 var pkgResponse = this.client.ExecuteAndDeserialize(new Upvote(packageId));
@@ -70,6 +76,8 @@ internal bool Upvote(string packageId)
 
         internal List<string> UserVotes()
         {
+            if (NoNetworkMode) return null;
+
             var votes = FailFunc.TryExecute(() =>
             {
                 var nv = new GetUserVotes();
@@ -82,6 +90,8 @@ internal List<string> UserVotes()
 
         internal List<JObject> CompatibilityMap()
         {
+            if (NoNetworkMode) return null;
+
             var compatibilityMap = FailFunc.TryExecute(() =>
             {
                 var cm = new GetCompatibilityMap();
@@ -99,6 +109,8 @@ internal PackageManagerResult DownloadPackage(string packageId, string version,
         {
             try
             {
+                if (NoNetworkMode) throw new Exception(DynamoPackages.Properties.Resources.DownloadPackageDisabled);
+
                 var response = this.client.Execute(new PackageDownload(packageId, version));
                 pathToPackage = PackageDownload.GetFileFromResponse(response);
                 return PackageManagerResult.Succeeded();
@@ -112,6 +124,8 @@ internal PackageManagerResult DownloadPackage(string packageId, string version,
 
         internal IEnumerable<PackageHeader> ListAll()
         {
+            if (NoNetworkMode) return new List<PackageHeader>();
+
             return FailFunc.TryExecute(() => {
                 var nv = HeaderCollectionDownload.ByEngine("dynamo");
                 var pkgResponse = this.client.ExecuteAndDeserializeWithContent<List<PackageHeader>>(nv);                
@@ -146,6 +160,8 @@ void CleanPackagesWithWrongVersions(List<PackageHeader> packages)
         /// <returns></returns>
         internal PackageHeader GetPackageMaintainers(IPackageInfo packageInfo)
         {
+            if (NoNetworkMode) return null;
+
             var header = FailFunc.TryExecute(() =>
             {
                 var nv = new GetMaintainers("dynamo", packageInfo.Name);
@@ -162,6 +178,8 @@ internal PackageHeader GetPackageMaintainers(IPackageInfo packageInfo)
         /// <returns></returns>
         internal UserPackages GetUsersLatestPackages()
         {
+            if (NoNetworkMode) return null;
+
             var packages = FailFunc.TryExecute(() =>
             {
                 var nv = new GetMyPackages();
@@ -179,6 +197,8 @@ internal UserPackages GetUsersLatestPackages()
         /// <returns>Package version metadata</returns>
         internal PackageVersion GetPackageVersionHeader(IPackageInfo packageInfo)
         {
+            if (NoNetworkMode) return null;
+
             var req = new HeaderVersionDownload("dynamo", packageInfo.Name, packageInfo.Version.ToString());
             var pkgResponse = this.client.ExecuteAndDeserializeWithContent<PackageVersion>(req);
             if (!pkgResponse.success)
@@ -196,6 +216,8 @@ internal PackageVersion GetPackageVersionHeader(IPackageInfo packageInfo)
         /// <returns>Package version metadata</returns>
         internal virtual PackageVersion GetPackageVersionHeader(string id, string version)
         {
+            if (NoNetworkMode) return null;
+
             var req = new HeaderVersionDownload(id, version);
             var pkgResponse = this.client.ExecuteAndDeserializeWithContent<PackageVersion>(req);
             if (!pkgResponse.success)
@@ -211,6 +233,8 @@ internal virtual PackageVersion GetPackageVersionHeader(string id, string versio
         /// </summary>
         internal virtual IEnumerable<string> GetKnownHosts()
         {
+            if (NoNetworkMode) return null;
+
             if (cachedHosts == null)
             {
                 cachedHosts = FailFunc.TryExecute(() =>
@@ -235,6 +259,8 @@ public bool SetTermsOfUseAcceptanceStatus()
 
         private bool ExecuteTermsOfUseCall(bool queryAcceptanceStatus)
         {
+            if (NoNetworkMode) return false;
+
             return FailFunc.TryExecute(() =>
             {
                 var request = new TermsOfUse(queryAcceptanceStatus);
@@ -258,6 +284,8 @@ private bool ExecuteTermsOfUseCall(bool queryAcceptanceStatus)
         /// <returns>A <see cref="PackageUploadHandle"/> Used to track the upload status.</returns>
         internal PackageUploadHandle PublishAsync(Package package, object files, IEnumerable<string> markdownFiles, bool isNewVersion, IEnumerable<string> roots, bool retainFolderStructure)
         {
+            if (NoNetworkMode) return null;
+
             var packageUploadHandle = new PackageUploadHandle(PackageUploadBuilder.NewRequestBody(package));
 
             Task.Factory.StartNew(() =>
@@ -321,6 +349,8 @@ internal void Publish(Package package, object files, IEnumerable<string> markdow
 
         internal PackageManagerResult Deprecate(string name)
         {
+            if (NoNetworkMode) return null;
+
             return FailFunc.TryExecute(() =>
             {
                 var pkgResponse = this.client.ExecuteAndDeserialize(new Deprecate(name, PackageEngineName));
@@ -330,6 +360,8 @@ internal PackageManagerResult Deprecate(string name)
 
         internal PackageManagerResult Undeprecate(string name)
         {
+            if (NoNetworkMode) return null;
+
             return FailFunc.TryExecute(() =>
             {
                 var pkgResponse = this.client.ExecuteAndDeserialize(new Undeprecate(name, PackageEngineName));
@@ -339,14 +371,16 @@ internal PackageManagerResult Undeprecate(string name)
 
         internal bool DoesCurrentUserOwnPackage(Package package,string username) 
         {
+            if (NoNetworkMode) return false;
+
             bool value;
-            if (this.packageMaintainers.Count > 0 && this.packageMaintainers.TryGetValue(package.Name, out value)) {
+            if (packageMaintainers.Count > 0 && packageMaintainers.TryGetValue(package.Name, out value)) {
                 return value;
             }
             var pkg = new PackageInfo(package.Name, new Version(package.VersionName));
             var mnt = GetPackageMaintainers(pkg);
             value = (mnt != null) && (mnt.maintainers.Any(maintainer => maintainer.username.Equals(username)));
-            this.packageMaintainers[package.Name] = value;
+            packageMaintainers[package.Name] = value;
             return value;
         }
 
@@ -386,7 +420,7 @@ internal void LoadCompatibilityMap()
             {
                 compatibilityMap = new Dictionary<string, Dictionary<string, string>>();
 
-                var compatibilityMapList = this.CompatibilityMap();
+                var compatibilityMapList = CompatibilityMap();
                 PackageManagerClient.compatibilityMapList = compatibilityMapList;    // Loads the full CompatibilityMap as a side-effect
 
                 foreach (var host in compatibilityMapList)

src/DynamoPackages/PackageManagerExtension.cs

@@ -157,11 +157,12 @@ public void Startup(StartupParams startupParams)
 
             var packageUploadDirectory = startupParams.PathManager.DefaultPackagesDirectory;
 
+            noNetworkMode = startupParams.NoNetworkMode;
+
             PackageManagerClient = new PackageManagerClient(
                 new GregClient(startupParams.AuthProvider, url),
-                uploadBuilder, packageUploadDirectory);
+                uploadBuilder, packageUploadDirectory, noNetworkMode);
 
-            noNetworkMode = startupParams.NoNetworkMode;
 
             //we don't ask dpm for the compatibility map in offline mode.
             if (!noNetworkMode)

src/DynamoPackages/Properties/Resources.en-US.resx

@@ -124,6 +124,9 @@
   <data name="CannotRemovePackageAssemblyTitle" xml:space="preserve">
     <value>Cannot update assembly</value>
   </data>
+  <data name="DownloadPackageDisabled" xml:space="preserve">
+    <value>Package download is disabled in no-network mode.</value>
+  </data>
   <data name="InvalidPackageFolderWarning" xml:space="preserve">
     <value>The folder '{0}' does not exist</value>
     <comment>This warning message is shown (during start up) when user specifies additional folders in DynamoSettings.xml file but the folders do not exist.</comment>
@@ -140,4 +143,4 @@
     <value>{0} was not scanned for packages because a preference setting disabled loading from that location."</value>
     <comment>This warning message is shown when a package directory is skipped due to a preference setting disabling loads from that location type.</comment>
   </data>
-</root>
+</root>

src/DynamoPackages/Properties/Resources.resx

@@ -124,6 +124,9 @@
   <data name="CannotRemovePackageAssemblyTitle" xml:space="preserve">
     <value>Cannot update assembly</value>
   </data>
+  <data name="DownloadPackageDisabled" xml:space="preserve">
+    <value>Package download is disabled in no-network mode.</value>
+  </data>
   <data name="InvalidPackageFolderWarning" xml:space="preserve">
     <value>The folder '{0}' does not exist</value>
     <comment>This warning message is shown (during start up) when user specifies additional folders in DynamoSettings.xml file but the folders do not exist.</comment>
@@ -140,4 +143,4 @@
     <value>{0} was not scanned for packages because a preference setting disabled loading from that location."</value>
     <comment>This warning message is shown when a package directory is skipped due to a preference setting disabling loads from that location type.</comment>
   </data>
-</root>
+</root>

src/Libraries/CoreNodeModels/WebRequest.cs

@@ -1,15 +1,17 @@
-using System;
+using System;
 using System.Collections.Generic;
 using CoreNodeModels.Properties;
 using DSCore;
+using Dynamo.Events;
 using Dynamo.Graph.Nodes;
+using Dynamo.Session;
 using Newtonsoft.Json;
 using ProtoCore.AST.AssociativeAST;
 
 namespace CoreNodeModels
 {
     [NodeName("Web Request")]
-    [NodeDescription("WebRequestDescription", typeof(Resources))]
+    [NodeDescription(nameof(Resources.WebRequestDescription), typeof(Resources))]
     [NodeCategory(BuiltinNodeCategories.CORE_WEB)]
     [IsDesignScriptCompatible]
     [OutPortTypes("var[]..[]")]