Explicitly allocate memory for slices#25
Open
hollowness-inside wants to merge 3 commits intoDylanMeeus:masterfrom
Open
Explicitly allocate memory for slices#25hollowness-inside wants to merge 3 commits intoDylanMeeus:masterfrom
hollowness-inside wants to merge 3 commits intoDylanMeeus:masterfrom
Conversation
hollowness-inside
changed the title
Owner
|
This looks good as is, thank you for the commits! I will check locally before merging in ~2 weeks (travelling without any machine to check). |
Starvin666
approved these changes
Dec 2, 2024
Starvin666
approved these changes
Dec 12, 2024
Starvin666
approved these changes
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate memory for slices explicitly. This eliminates unnecessary memory allocations and copies when appending to the slice.