ModelInterface addition to clean up ApiClient::deserialize call #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiggott
changed the title
ApiClient::deserialize call
cpiggott
changed the title
ApiClient::deserialize call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
ModelInterfaceto clean up the calls that used unknown variables in theApiClient::deserializecall for Swagger based models.This removes "breaking" errors when running a php code-sniffer to check for inconsistencies throughout the code-base.
I was unable to find any tests to run this against, so if you have them on your end and would like to test them, please let me know if you find any issue and I'll be happy to clean them up.