Conversation
|
Också, |
|
Också, från instruktionerna (#947)
|
christofergartner
left a comment
There was a problem hiding this comment.
Does NOT work on my machine. Safari macOS 26.3.
User error |
|
As per my last review, it is hard to see what is changed from shadcn, I'd reccomend rebasing. Nonetheless, running the first example on the kbd page i get an error. <div class="flex flex-col items-center gap-4">
<Kbd.Group>
<Kbd.Root>⌘</Kbd.Root>
<Kbd.Root>⇧</Kbd.Root>
<Kbd.Root>⌥</Kbd.Root>
<Kbd.Root>⌃</Kbd.Root>
</Kbd.Group>
<Kbd.Group>
<Kbd.Root>Ctrl</Kbd.Root>
<span>+</span>
<Kbd.Root>B</Kbd.Root>
</Kbd.Group>
</div>This gives me |
|
Thanks will fix! |
|
Fully reworked component and correctly committed component addition before customization for a clearer diff.
Key features:
Successfully tested with: <script>
import NotImplemented from "$lib/components/NotImplemented.svelte";
import { Kbd, KbdGroup } from "$lib/components/ui/kbd";
import Footer from "./(app)/Footer.svelte";
import Navbar from "./(app)/Navbar.svelte";
</script>
<nav class="contents">
<Navbar />
</nav>
<div class="flex flex-col items-center gap-4">
<KbdGroup>
<Kbd symbol="⌘" trigger="Meta" />
<Kbd symbol="⇧" trigger="Shift" />
<Kbd symbol="⌥" trigger="Alt" />
<Kbd symbol="⌃" />
</KbdGroup>
<KbdGroup>
<Kbd symbol="Ctrl" trigger="Control" />
<span>+</span>
<Kbd symbol="B" caseInsensitive />
</KbdGroup>
</div>
<NotImplemented />
<Footer />
|
Correctly highlights multiple keys when pressed simultaneously
SLUCHABLUB
left a comment
There was a problem hiding this comment.
Only one question, otherwise it looks great. Good job!
SLUCHABLUB
left a comment
There was a problem hiding this comment.
Looks good! I assume that it works on MacOS now too.
@christofergartner pls test, haven't been able to test Safari. |
|
@Fiery-132 Verified on Safari! |
* Add kbd component * Customize kbd component Correctly highlights multiple keys when pressed simultaneously


🧩 Summary
Look at title
🔗 Related issues (if any)
Closes #961
📸 Screenshots / recordings (if applicable)
Run and look or smth
💬 Other information
None