Default exception handlers for deferred database calls#469
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@owlplug-client/src/main/java/com/owlplug/core/utils/Async.java`:
- Around line 38-77: Add executor-aware overloads for the blocking variants so
callers can supply a dedicated Executor rather than always using
ForkJoinPool.commonPool(): add public static CompletableFuture<Void>
run(Runnable task, Executor exec) and public static <T> CompletableFuture<T>
supply(Supplier<T> task, Executor exec) that call CompletableFuture.runAsync/
supplyAsync with the provided exec and attach the same whenComplete logging
handler; keep the existing run(Runnable) and supply(Supplier) as convenience
wrappers that delegate to the new overloads using ForkJoinPool.commonPool() to
preserve backward compatibility; update javadoc comments for run/supply to note
the executor-aware overloads and when to use the raw runAsync/supplyAsync
helpers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 59a9ef41-59fe-45dc-8b20-d9f85f499e31
📒 Files selected for processing (5)
owlplug-client/src/main/java/com/owlplug/core/utils/Async.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginInfoController.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginTableController.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginsController.javaowlplug-client/src/main/java/com/owlplug/plugin/ui/RecoveredPluginView.java
Relates to #467