This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Swift 4 update.#4
Open
roselloryan wants to merge 16 commits into
Open
Conversation
… and removed unecessary cast to clear warning
…ather than image orientation
…o detailView to follow device orientation
PChmiel
reviewed
Jan 26, 2018
| return devices.filter { $0.position == .front }.first | ||
| let discoverySession = AVCaptureDevice.DiscoverySession.init(deviceTypes: [AVCaptureDevice.DeviceType.builtInWideAngleCamera], mediaType: .video, position: AVCaptureDevice.Position.front) | ||
|
|
||
| return discoverySession.devices.count > 0 ? discoverySession.devices.first : nil |
Contributor
There was a problem hiding this comment.
you can just return discoverySession.devices.first, its optional
|
|
||
| let attachments = CMCopyDictionaryOfAttachments(kCFAllocatorDefault, sampleBuffer, kCMAttachmentMode_ShouldPropagate) | ||
|
|
||
| let ciImage = CIImage(cvImageBuffer: pixelBuffer!, options: attachments as! [String : Any]?) |
Contributor
There was a problem hiding this comment.
add guards above instead of using !
| "has closed left eye: \(faceFeature.leftEyeClosed)", | ||
| "has closed right eye: \(faceFeature.rightEyeClosed)"] | ||
| "has closed right eye: \(faceFeature.leftEyeClosed)", |
Author
There was a problem hiding this comment.
No. I will set it back to the original orientation.
| } | ||
|
|
||
| func exifOrientation(orientation: UIDeviceOrientation) -> Int { | ||
|
|
|
|
||
| DispatchQueue.main.async { | ||
| UIView.animate(withDuration: 0.2) { | ||
| UIView.animate(withDuration: 0.2) { [unowned self] in |
Contributor
There was a problem hiding this comment.
in case of animation there is no need to use unowned or weak
| } | ||
|
|
||
| func rotateDetailViewWithDeviceOrientation() { | ||
| switch UIDevice.current.orientation { |
Contributor
There was a problem hiding this comment.
change formatting and remove new lines
| switch UIDevice.current.orientation { | ||
|
|
||
| case .portrait: | ||
| self.detailsView.transform = CGAffineTransform(rotationAngle: 0) |
Contributor
There was a problem hiding this comment.
self is not necessary here and below
| case .portraitUpsideDown: | ||
| self.detailsView.transform = CGAffineTransform(rotationAngle: CGFloat.pi) | ||
|
|
||
| default: |
Author
There was a problem hiding this comment.
Awesome. Thank you for your help.
| @@ -1,4 +1,4 @@ | |||
| // | |||
| // | |||
| guard let devices = AVCaptureDevice.devices(withMediaType: AVMediaTypeVideo) as? [AVCaptureDevice] else { return nil } | ||
|
|
||
| return devices.filter { $0.position == .front }.first | ||
| let discoverySession = AVCaptureDevice.DiscoverySession.init(deviceTypes: [AVCaptureDevice.DeviceType.builtInWideAngleCamera], mediaType: .video, position: AVCaptureDevice.Position.front) |
Contributor
There was a problem hiding this comment.
.init is not neccessary just ...DiscoverySession(deviceTypes:...
Author
|
I don't understand why the tests fail. Can anyone help? |
Member
|
This project is no longer maintained and will be archived. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found your project reading about face tracking and wanted to thank you by updating it up for others to find and learn from.
Fixed face tracking to work for all device orientations and added DetailView rotation to match the orientation of user's face.
Assuming the user is turning the device and not the other way around.
Thanks!