ignore if path is falsy#5
Open
bv-loveholidays wants to merge 3 commits into
Open
Conversation
claudiordgz
added a commit
to claudiordgz/webpack-emit-all-plugin
that referenced
this pull request
Jul 1, 2018
claudiordgz
added a commit
to claudiordgz/webpack-emit-all-plugin
that referenced
this pull request
Jul 1, 2018
Owner
|
(Leaving a reminder for myself) document in README once merged. Will merge this at the same time as #6. Thanks @bv-loveholidays! |
Author
|
@DrewML no worries :) |
|
@DrewML Any updates on when this could be merged? |
|
I know free maintenance work is a thankless chore, but is there a possibility to merge this? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting a problem with a resource path being undefined. Not sure if it was due to our code splitting setup, but this fixed the problem for us.
Also we need the ability to transform filenames because we're using .jsx endings which doesn't work well with node module requires.