Tavroswyn ktc suggestions #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am missing references in the KTC-easy guide, that the print_start and print_end macros need to be adjusted. I am unsure about the right location, so here is a suggestion, where it fits kind of well for me.
Also, I had an issue with the example PRINT_START macro, because I hadn't set up the Slicer yet to supply the TOOL argument. This doesn't fail initially, because the macro defines 0 as default. But there are two places, where param.TOOL is called instead, which does not get this default argument treatment. Therefore, I am suggesting, to consistently use just TOOL. (+ wrong indentation in the first affected line fixed).