Further refinements to the Driver Config API#166
Merged
rneswold merged 9 commits intoDrMemCS:mainfrom Jan 26, 2026
Merged
Conversation
I set up a DrMem node with a logic node in which a `def` expression could return no value (i.e. no "else" clause in an "if-statement".) I wasn't sure it would get forwarded to the controlling expression. This commit adds a test that verifies yes, if a `def` doesn't return a value, then the device doesn't get updated.
With this commit, the driver and registrator APIs share the type of the configuration instead of each of them parsing the TOML data. The driver manager will do the conversion and pass the type to each method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ties the configuration structure to both the driver and the Registrator. By tying them together with the type system, the driver manager can convert the TOML entries into the Rust structure and then pass it to both methods.