Conversation
It's -33 F windchill in Chicago and the dewpoint is reported as -21 F. So clipping it at 0 F doesn't seem right. We'll just let the Weather Underground data go through. It's easy enough to use a logic block to clip bad values if you're using a station that generates them (bad values.)
The new `serde`-based driver config code can support enums directly so we're sort of exposing what we use for the units. The "units" parameter now needs to be "English" or "Metric".
Having "Shared" in the name was confusing, according to ChatGPT. I can see why that might be the case. So this commit renames `SharedReadWriteDevice` to `OverridableDevice`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes found after the last PR.