Conversation
The `TimeVal` value of the enum was generating a warning because you can't derive `PartialEq` on function pointers. This commit refactors the `TimeVal` variant: - Removed the function parameter. There is now a method added to the `TimeField` enum to pull the correct field from the time. - The first param is now a `Zone` enum so we don't have to check for inifinite possible categories in the first param (it was a `&str`.)
The function parameter was causing warnings because `PartialEq` can't be derived for functions (even static function pointers.) This commit introduces a better way to pull solar values from the structure.
Indicate which argument of the AND and OR expressions was at fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the TP-Link driver, I stumbled across some code I thought could be improved. I made those changes on this branch. They'll get merged with my TP-Link branch later.