Conversation
My house had a power outage in the middle of the night that lasted longer than my UPS. My SSD's filesystem had some corruption. I was able to recover some of the work that I did, but lost some, too. This commit has some of the work and compiles and passes unit tests. I'll need to recreate the rest of the work in future commits.
This removes a `todo!` macro. When reporting a polled value, we weren't handleing the `SettingTrans` state. Now we are.
If the device is synced and a setting comes in with the same value, we weren't letting the client know the setting succeeded.
Now all the states are handled by both update methods.
Add messages that announce when we enter and leave override mode.
I've started switching my shell script's commands into a single `just` file.
This allows us to run the tests on just this driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of device handler, a
SharedReadWriteDevice. This device type is to be used for devices that are controlled by DrMem, but can also be controlled manually. A driver will typically poll the hardware to get its current state. It also waits for settings from clients. This handler allows the device to be overridden and then get back in sync after a timeout.It should be used for devices, like Wifi LED bulbs.