Conversation
This adds the types and query so GraphQL clients can glean information about the configured logic blocks in a DrMem node. This feature isn't complete yet, however. It returns information from the `Context` of the GraphQL service which, currently, only has an empty list. The next step is to fill it with config information.
The GraphQL query now returns LogicBlock information.
- undo some of the changes I made; make functions `async` instead of specifying the Future it returns. - use `.div_ceil()`
This is test code and only one location called `Emulator::new` so I merged it into the place where it was used.
The change in the logic module broke the unit tests because the initialization of the logic block happened outside of the async task. The unit test started an emulator which wasn't ready when the logic block was making requests. This change simply clones the Logic config so that we don't have to make the change to the Logic block initialization.
Contributor
Author
|
I ran some GraphQL queries against it and was able to view the Logic Block information. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the query for the Logic Blocks.