Implement ticket password feature in dl-cli.py#82
Open
egcmi wants to merge 1 commit intoDownloadTicketService:masterfrom
Open
Implement ticket password feature in dl-cli.py#82egcmi wants to merge 1 commit intoDownloadTicketService:masterfrom
egcmi wants to merge 1 commit intoDownloadTicketService:masterfrom
Conversation
Add ticket password generation using secrets module
Member
|
This breaks the output interface though. I would prefer that the password is provided externally instead, via stdin or input file for example, like rsync does. This would still work very well with shell scripts, for example when using "pwgen" gives you full control: umask 077
pwgen -1 > pass
dl-cli --password-file pass <file to upload>Handling "--password-file=-" would be a bonus, but we do have /dev/stdin for this anyway. If you run dl-cli as a subprocess, stdin avoids the need to create temporary files entirely and is secure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ticket password generation using secrets module
Enable ticket password generation in configuration file by setting
ticket_pass=TRUE. ticket_pass value must be boolean. the generated token will be printed to the console