Skip to content

Fix subject Id overflow in datahub table#1328

Open
david-roper wants to merge 2 commits intoDouglasNeuroInformatics:mainfrom
david-roper:fix-subject-overflow
Open

Fix subject Id overflow in datahub table#1328
david-roper wants to merge 2 commits intoDouglasNeuroInformatics:mainfrom
david-roper:fix-subject-overflow

Conversation

@david-roper
Copy link
Copy Markdown
Collaborator

@david-roper david-roper commented Mar 31, 2026

Use antigravity (gemini 3.1) to fix subject id overflow

implements a within cell scroll bar for overflowing subject ids.

closes issue #1318

Summary by CodeRabbit

  • Bug Fixes
    • Table now displays truncated subject IDs for readability while exposing the full ID via native browser tooltip on hover, improving copy/inspect behavior for long values.

@david-roper david-roper requested a review from joshunrau as a code owner March 31, 2026 19:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 23dd194f-f702-4a4d-bee5-f1ee77029690

📥 Commits

Reviewing files that changed from the base of the PR and between c598121 and 4a2fd4f.

📒 Files selected for processing (1)
  • apps/web/src/routes/_app/datahub/index.tsx
✅ Files skipped from review due to trivial changes (1)
  • apps/web/src/routes/_app/datahub/index.tsx

Walkthrough

Replaced the truncated subjectId accessor with the full value and added a custom cell renderer that shows truncated text inside a horizontally scrollable element while exposing the complete ID via the title attribute (native tooltip).

Changes

Cohort / File(s) Summary
Table Cell Renderer Enhancement
apps/web/src/routes/_app/datahub/index.tsx
Replaced truncated accessorFn for subjectId with full removeSubjectIdScope(subject.id) and added a cell renderer that truncates visible text in a horizontally scrollable container and sets title to ctx.getValue() for tooltip/full value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • joshunrau
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix subject Id overflow in datahub table' directly describes the main change: addressing subject ID overflow in the datahub table by implementing a cell renderer with truncation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/src/routes/_app/datahub/index.tsx`:
- Around line 311-317: The cell renderer is showing a truncated subject ID
because it uses ctx.getValue() which reflects the sliced value from the column
accessor; update the cell renderer (the cell function) to read and display the
full subject ID instead of the pre-sliced value: use the original row value
(e.g., ctx.row.original.subject.id or the full subject ID property on
ctx.row.original) for the tooltip (title) and for the hidden/scrollable content
while keeping the visible truncated text if desired; ensure ctx.getValue() is
only used for the displayed short form, and reference
ctx.row.original.subject.id (or the actual full-id property name) for the
tooltip/overflow container so the scrollbar can reveal the full ID.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3383dcd1-3446-43ea-b916-51d4c478a2fa

📥 Commits

Reviewing files that changed from the base of the PR and between 879da83 and c598121.

📒 Files selected for processing (1)
  • apps/web/src/routes/_app/datahub/index.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant