Fix subject Id overflow in datahub table#1328
Fix subject Id overflow in datahub table#1328david-roper wants to merge 2 commits intoDouglasNeuroInformatics:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughReplaced the truncated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/web/src/routes/_app/datahub/index.tsx`:
- Around line 311-317: The cell renderer is showing a truncated subject ID
because it uses ctx.getValue() which reflects the sliced value from the column
accessor; update the cell renderer (the cell function) to read and display the
full subject ID instead of the pre-sliced value: use the original row value
(e.g., ctx.row.original.subject.id or the full subject ID property on
ctx.row.original) for the tooltip (title) and for the hidden/scrollable content
while keeping the visible truncated text if desired; ensure ctx.getValue() is
only used for the displayed short form, and reference
ctx.row.original.subject.id (or the actual full-id property name) for the
tooltip/overflow container so the scrollbar can reveal the full ID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3383dcd1-3446-43ea-b916-51d4c478a2fa
📒 Files selected for processing (1)
apps/web/src/routes/_app/datahub/index.tsx
Use antigravity (gemini 3.1) to fix subject id overflow
implements a within cell scroll bar for overflowing subject ids.
closes issue #1318
Summary by CodeRabbit