Skip to content

Add gitignore & Remove chat log from source code#41

Open
Preloading wants to merge 4 commits intoDougDougGithub:mainfrom
Preloading:patch-1
Open

Add gitignore & Remove chat log from source code#41
Preloading wants to merge 4 commits intoDougDougGithub:mainfrom
Preloading:patch-1

Conversation

@Preloading
Copy link

@Preloading Preloading commented Jan 13, 2024

Removes the Chat log file, and adds a proper gitignore. Btw, all you need to click is Accept Merge Request, you don't need to click the buttons approve the PR right before you're going to merge it.

@Preloading
Copy link
Author

also i love your videos, will this be turned into a video? I am a first time twitch chatter, and i love the coding, please post meme generator and https://flexboxfroggy.com/ it very easy

@Preloading Preloading changed the title Remove Chat log to improve download times Remove Chat log to improve download times + gitignore Jan 13, 2024
Copy link

@tizu69 tizu69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I'm not sure if that huge gitignore is faster to download than the chat history.. but whatever, lgtm

@benny-yamagata

This comment was marked as resolved.

@fily-gif
Copy link

Saying you don't need to review just hit accept merge request is just a red flag to review even more thoroughly.

I would hope that anyone who is maintaining open source code would review any merge requests, especially when they know that code may be consumed by thousands of individuals.

LGTM, they just pasted a .gitignore template and added the chat log

@Preloading
Copy link
Author

Saying you don't need to review just hit accept merge request is just a red flag to review even more thoroughly.

I would hope that anyone who is maintaining open source code would review any merge requests, especially when they know that code may be consumed by thousands of individuals.

Yes I am aware, I am saying that you don't need to click the few approve this code buttons, right before merging, not that you don't need to review the code, to see that it is safe, etc before you merge.

@Preloading
Copy link
Author

Preloading commented Jan 14, 2024

Saying you don't need to review just hit accept merge request is just a red flag to review even more thoroughly.

I would hope that anyone who is maintaining open source code would review any merge requests, especially when they know that code may be consumed by thousands of individuals.

LGTM, they just pasted a .gitignore template and added the chat log

I added the python template, removed the chat log file, and added the chat log to the gitignore, before more PRs were merged, already doing the stuff. It's small, but isn't this Doug's first time using GitHub? He wouldn't figure out gitignore for a while. It was mainly intended to prevent the chat log, which could potentially contain stuff that you don't want on a public repo. Download times, was because every single commit, you would need to redownload the chat log, and they could get long fast

@Preloading
Copy link
Author

I have also resolved the merge conflict

@Preloading Preloading changed the title Remove Chat log to improve download times + gitignore Add gitignore & Remove chat log from source code Jan 14, 2024
@Preloading
Copy link
Author

And changed the title to be more reflective

Copy link

@FifthTundraG FifthTundraG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User-generated logs like ChatHistoryBackup.txt shouldn't be included in an open-source repo, anyway.

@Preloading
Copy link
Author

User-generated logs like ChatHistoryBackup.txt shouldn't be included in an open-source repo, anyway.

yes... thats what this was suppose to solve

@benny-yamagata
Copy link

Saying you don't need to review just hit accept merge request is just a red flag to review even more thoroughly.

I would hope that anyone who is maintaining open source code would review any merge requests, especially when they know that code may be consumed by thousands of individuals.

Yes I am aware, I am saying that you don't need to click the few approve this code buttons, right before merging, not that you don't need to review the code, to see that it is safe, etc before you merge.

My bad, misunderstood the intent!

Copy link

@StealthBadger747 StealthBadger747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic stuff. LGTM

@aprilthepink
Copy link

I would hope that anyone who is maintaining open source code would review any merge requests, especially when they know that code may be consumed by thousands of individuals.

so much this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants