Add gitignore & Remove chat log from source code#41
Add gitignore & Remove chat log from source code#41Preloading wants to merge 4 commits intoDougDougGithub:mainfrom
Conversation
|
also i love your videos, will this be turned into a video? I am a first time twitch chatter, and i love the coding, please post meme generator and https://flexboxfroggy.com/ it very easy |
tizu69
left a comment
There was a problem hiding this comment.
yea I'm not sure if that huge gitignore is faster to download than the chat history.. but whatever, lgtm
This comment was marked as resolved.
This comment was marked as resolved.
LGTM, they just pasted a .gitignore template and added the chat log |
Yes I am aware, I am saying that you don't need to click the few approve this code buttons, right before merging, not that you don't need to review the code, to see that it is safe, etc before you merge. |
I added the python template, removed the chat log file, and added the chat log to the gitignore, before more PRs were merged, already doing the stuff. It's small, but isn't this Doug's first time using GitHub? He wouldn't figure out gitignore for a while. It was mainly intended to prevent the chat log, which could potentially contain stuff that you don't want on a public repo. Download times, was because every single commit, you would need to redownload the chat log, and they could get long fast |
|
I have also resolved the merge conflict |
|
And changed the title to be more reflective |
FifthTundraG
left a comment
There was a problem hiding this comment.
User-generated logs like ChatHistoryBackup.txt shouldn't be included in an open-source repo, anyway.
yes... thats what this was suppose to solve |
My bad, misunderstood the intent! |
so much this! |
Removes the Chat log file, and adds a proper gitignore. Btw, all you need to click is Accept Merge Request, you don't need to click the buttons approve the PR right before you're going to merge it.