Skip to content

added functionality to mark users as churned#4

Open
vivek-kumar-pandey wants to merge 6 commits into
developfrom
feature/function-to-update-churned-user-group
Open

added functionality to mark users as churned#4
vivek-kumar-pandey wants to merge 6 commits into
developfrom
feature/function-to-update-churned-user-group

Conversation

@vivek-kumar-pandey

Copy link
Copy Markdown
Contributor

Please complete the following steps and check these boxes before filing your PR:

DostEducation/RP_IVR_analytics#363

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

Creating the feature for fetching the churned users and marking them churned

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.

@GauravGusain98 GauravGusain98 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, please check

Comment thread api/models/user.py Outdated
Comment thread main.py Outdated
Comment thread api/services/rapid_pro_services/update_user_group.py Outdated
Comment thread api/services/rapid_pro_services/update_user_group.py Outdated
Comment thread api/services/rp_ivr_system_services/churn_users.py
Comment thread api/services/rp_ivr_system_services/churn_users.py

@GauravGusain98 GauravGusain98 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions, please check

Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated
Comment thread api/services/rapid_pro_services/update_user_group_service.py Outdated

@GauravGusain98 GauravGusain98 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated
Comment thread api/services/rapid_pro_services/update_user_group_service.py Outdated
Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated
Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated
Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated
Comment thread api/services/rp_ivr_system_services/churn_users_service.py Outdated

@GauravGusain98 GauravGusain98 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants