Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[REFACTOR] DB Flush 호출 최소화 및 전역 Soft Delete 적용 #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[REFACTOR] DB Flush 호출 최소화 및 전역 Soft Delete 적용 #102
Changes from all commits
e91460c57c4702b3a03b86203a3ab0f8694e013bfbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚖️ Poor tradeoff
BaseEntity와 동일한 소프트 삭제 패턴이 중복 구현되어 있습니다.deletedAt,isDeleted(),delete()는BaseEntity에 이미 동일하게 정의된 패턴입니다.ChecklistBase가BaseEntity를 상속하지 않기 때문에 부득이하게 중복이 발생했지만, 향후 두 구현이 따로 관리되면 타임존 처리나 감사(Auditing) 로직 변경 시 한 쪽이 누락될 위험이 있습니다.ChecklistBase가BaseEntity를 상속하도록 리팩토링하거나, 소프트 삭제 로직을 별도의@MappedSuperclass(예:SoftDeletableEntity)로 추출하는 방향을 장기적으로 검토해 보시면 좋겠습니다.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | 💤 Low value
빈
indexes블록 정리를 고려해 주세요.현재 인덱스가 정의되어 있지 않다면
@Table어노테이션에서indexes속성을 제거하여 코드를 간결하게 유지할 수 있습니다. 다만 스키마에서 Partial Index를 별도로 관리하고 있다면 현재 상태로 두셔도 무방합니다.🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | 💤 Low value
uk_chat_room_group도 방어적으로DROP CONSTRAINT IF EXISTS를 함께 추가하는 것이 어떨까요?라인 9-34에서 적용한 패턴(이전 리뷰 반영)과 비교했을 때,
chat_room의 경우uk_chat_room_direct는 라인 47-48에서DROP CONSTRAINT, 라인 55에서DROP INDEX로 양쪽 케이스를 모두 처리하지만,uk_chat_room_group은 라인 50의DROP INDEX IF EXISTS만 존재합니다.현재 코드베이스 기준으로는 GROUP 인덱스가 INDEX 형태로만 존재했을 가능성이 높지만, 과거 마이그레이션 이력이나 환경별 차이를 고려하면
direct와 동일하게 양쪽 모두 방어적으로 처리해두는 편이 일관성 측면에서도, 운영 안정성 측면에서도 더 좋을 것 같습니다.🛡️ 제안 수정
📝 Committable suggestion
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.