[S24] test : s18 cert validation hardening (harness-based)#130
Merged
[S24] test : s18 cert validation hardening (harness-based)#130
Conversation
Upgrade releaseCert.ts with stderr/log monitoring using DI + fixture harness tests. No crash probes, no env-var toggles, no force-dynamic in app routes. Changes: - Add STDERR_SIGNATURES list (12 patterns) for server log scanning - Add StderrCheck interface and checkServerLog() function - Extend runCert() with RunCertOptions.serverLogPath for stderr checking - Add harness tests proving overlay-fallacy: HTTP 200 + clean HTML + stderr crash = old cert false-PASS, upgraded cert correct FAIL - Audit confirms zero crash-probe remnants in app routes AT-S24-01: Audit PASS (grep + page.tsx verification) AT-S24-02: Harness proves old overlay-only detection false-PASS AT-S24-03: Upgraded cert FAILS for 200 + stderr crash AT-S24-04: Upgraded cert PASSES for 200 + clean stderr AT-S24-05: Main-only enforcement preserved (existing checkBranch tests) Co-Authored-By: Claude <noreply@anthropic.com>
Doogie201
added
evidence:attached
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e616273e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
checkServerLog now returns ok:false with LOG_READ_FAILED marker when logPath is provided but the file cannot be read, preventing silent false-PASS due to missing evidence (AT-S24-06). Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Doogie201
added a commit
that referenced
this pull request
Feb 24, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
Doogie201
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint S24 — S18 Cert Validation Hardening (Harness-Based)
Sprint ID:
S24-s18-validationObjective: Validate that the S18/S18v2 cert cannot false-PASS when stderr/hydration failures occur with HTTP 200 using a harness-based approach (DI + fixtures), and audit main to ensure zero crash-probe remnants in app routes.
No crash probes / no env-var toggles / no force-dynamic used for evidence.
Log capture is fail-closed when serverLogPath is provided (unreadable log = FAIL, not silent PASS).
Acceptance Tests
Evidence
See
docs/sprints/S24/evidence/for all JSON receipts (AT-01 through AT-06 + gates).Budget
releaseCert.tsreleaseCert.test.tsMarker Lists
OVERLAY_MARKERS: nextjs-portal, data-nextjs-dialog, data-nextjs-error, nextjs__container_errors, Unhandled Runtime Error, Maximum update depth exceeded, Internal Server Error, Application error: a server-side exception has occurred, Hydration failed
STDERR_SIGNATURES: ⨯ Error, TypeError:, ReferenceError:, SyntaxError:, RangeError:, ECONNREFUSED, EADDRINUSE, unhandledRejection, uncaughtException, Hydration failed, digest:, server-side exception
Fail-closed marker: LOG_READ_FAILED
Gates