fix(plane): add http scheme to WEB_URL#715
fix(plane): add http scheme to WEB_URL#715adryserage wants to merge 2 commits intoDokploy:canaryfrom
Conversation
WEB_URL needs a scheme for Plane to generate valid links. Using http:// since Traefik handles SSL termination.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Additional Comments (1)
|
There was a problem hiding this comment.
Pull request overview
Updates the Plane blueprint’s environment configuration to ensure WEB_URL includes an explicit http:// scheme, so Plane can generate valid absolute links when deployed behind Dokploy/Traefik.
Changes:
- Set
WEB_URLtohttp://…instead of a schemeless value in Plane’stemplate.toml.
blueprints/plane/template.toml
Outdated
| "Domain=${domain}", | ||
| "WEB_URL=${Domain}", | ||
| "WEB_URL=http://${Domain}", |
There was a problem hiding this comment.
WEB_URL is being built with ${Domain}, but Domain is only an env var entry ("Domain=...") and is not defined under [variables]. As a result, Dokploy interpolation likely won’t replace ${Domain}, leaving the literal string http://${Domain} and breaking Plane’s generated links. Use ${main_domain} (or ${domain}) directly in WEB_URL (and avoid referencing other env vars inside ${...}).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
Changes
Context
Follows up on #582 (closed for inactivity). Addresses review feedback from @Siumauricio — removed \https://\ and kept \API_BASE_URL\ as internal \http://api:8000\.
Testing
Verified template.toml syntax is valid.
Greptile Summary
Added
http://scheme toWEB_URLenvironment variable so Plane can generate valid absolute URLs for emails, redirects, and other features. The change correctly useshttp://instead ofhttps://since Traefik handles SSL termination at the proxy level.WEB_URLto includehttp://scheme prefix (was missing protocol entirely)http://${domain}pattern for internal URLsCORS_ALLOWED_ORIGINSstill useshttps://which may cause CORS errorsConfidence Score: 4/5
WEB_URL(http) andCORS_ALLOWED_ORIGINS(https) that should be verified in testingCORS_ALLOWED_ORIGINSconfiguration in production to ensure no CORS errors occurLast reviewed commit: 36194c6