feat: Add imgproxy template#714
Open
vladyslavprosolupov wants to merge 8 commits intoDokploy:canaryfrom
Open
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Dokploy blueprint for deploying imgproxy (image processing proxy) with an nginx front-end for response caching, and registers it in the repository’s template index (meta.json).
Changes:
- Added
blueprints/imgproxy/includingdocker-compose.yml,template.toml, and a logo. - Added
imgproxyentry tometa.json(and adjustedstrapiplacement as part of meta ordering/cleanup).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| meta.json | Registers the new imgproxy template metadata and adjusts ordering around existing entries. |
| blueprints/imgproxy/template.toml | Introduces Dokploy variables/env/domain mapping for imgproxy + nginx caching tunables. |
| blueprints/imgproxy/docker-compose.yml | Defines imgproxy service and nginx caching reverse proxy configuration. |
| blueprints/imgproxy/imgproxy.png | Adds the template logo asset referenced by meta.json. |
Comments suppressed due to low confidence (1)
meta.json:3106
- PR description/checklist claims tests were added, but this PR only adds the blueprint/meta entries and doesn’t introduce any automated tests. Please update the PR description/checklist to reflect the actual validation performed (typically Dokploy preview/manual deploy verification in this repo).
{
"id": "imgproxy",
"name": "imgproxy",
"version": "v3.30.1",
"description": "imgproxy is a fast and secure image processing server, fronted by nginx with built-in response caching for repeated transformations.",
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
blueprints/imgproxy/docker-compose.yml:5
- The imgproxy service should explicitly declare the port it exposes using the
exposedirective. Addexpose: - 8080after line 5 to document that imgproxy listens on port 8080, which is referenced by the nginx proxy configuration at line 69. This follows the convention used in other multi-service templates and improves clarity.
imgproxy:
image: darthsim/imgproxy:v3.30.1
restart: unless-stopped
blueprints/imgproxy/template.toml:43
- Several environment variables are set to empty strings (IMGPROXY_CONCURRENCY, IMGPROXY_SO_REUSEPORT, IMGPROXY_USER_AGENT) both in template.toml and docker-compose.yml. Empty strings might not be the intended default for these settings. Consider either removing these variables entirely (letting imgproxy use its own defaults) or providing sensible default values. For example, IMGPROXY_CONCURRENCY could be set based on available CPU cores.
IMGPROXY_CONCURRENCY = ""
IMGPROXY_MAX_CLIENTS = "${imgproxy_max_clients}"
IMGPROXY_SO_REUSEPORT = ""
IMGPROXY_USER_AGENT = ""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
New PR of imgproxy - fast and secure on the fly image processing
Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
Close automatically the related issues using the keywords:
closes #ISSUE_NUMBERScreenshots or Videos
Greptile Summary
This PR adds a new imgproxy template for fast and secure on-the-fly image processing. The implementation includes a two-service setup with imgproxy for image processing and nginx as a caching reverse proxy.
Key changes:
blueprints/imgproxy/withdocker-compose.yml,template.toml, and logo${hash:128})meta.jsonwith correct metadata and proper alphabetical orderingIssues found:
nginxservice usesportsinstead ofexpose, which violates template requirements (AGENTS.md line 150)imgproxyservice should explicitly declareexpose: - 8080for documentationConfidence Score: 4/5
portsinstead ofexposein the nginx service, which violates documented template requirements. Once this syntax issue is corrected, the template will be production-ready.blueprints/imgproxy/docker-compose.yml- needsportschanged toexposeLast reviewed commit: ca6edf5
(2/5) Greptile learns from your feedback when you react with thumbs up/down!
Context used:
dashboard- AGENTS.md (source)