Skip to content

Added the frappe lending template#665

Open
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Harikrishnan1367709:Add-Frappe-lending-Template
Open

Added the frappe lending template#665
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Harikrishnan1367709:Add-Frappe-lending-Template

Conversation

@Harikrishnan1367709
Copy link
Contributor

@Harikrishnan1367709 Harikrishnan1367709 commented Jan 19, 2026

Description

Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Technical Details

  • Base Image: frappe/erpnext:v15
  • Apps: ERPNext + Lending
  • Services: Backend, Frontend (Nginx), MariaDB, Redis, Queue Workers
  • Port: 8080
Screenshot 2026-01-13 at 5 55 37 PM

Greptile Summary

Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Key changes:

  • New blueprint directory with docker-compose.yml, template.toml, and logo
  • Configured services: backend, frontend (Nginx), MariaDB, Redis, queue workers (default, long, short), scheduler, websocket
  • Added configurator and create-site services for initial setup
  • Configured lending app installation and site creation logic
  • Added entry to meta.json with appropriate tags

Issues identified:

  • Missing version: "3.8" field at the start of docker-compose.yml (required by style guide)
  • Using VERSION=latest in template.toml and meta.json instead of pinning to specific version like v15

Positive aspects:

  • Correctly avoids using networks (unlike other frappe templates in the repo)
  • Correctly avoids using ports and container_name directives
  • Proper use of volumes for data persistence
  • Comprehensive healthchecks and service dependencies

Confidence Score: 4/5

  • This PR is safe to merge with minor fixes needed
  • The template follows most Dokploy conventions and adds a functional Frappe Lending deployment. The issues found are primarily style-related (missing version field, using latest instead of pinned version). The template correctly avoids problematic directives like networks, ports, and container_name. Once the version field is added and versions are pinned, this will be fully compliant.
  • docker-compose.yml needs version field added, template.toml and meta.json need version pinning from latest to v15

Last reviewed commit: 9c637bb

Context used:

  • Context from dashboard - AGENTS.md (source)

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
templates ✅ Ready (View Log) Visit Preview 9c637bb

@Siumauricio
Copy link
Contributor

@greptile review

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@@ -0,0 +1,550 @@
x-custom-image: &custom_image
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version: "3.8" at the start of the file

Suggested change
x-custom-image: &custom_image
version: "3.8"
x-custom-image: &custom_image

Context Used: Context from dashboard - AGENTS.md (source)

"REGENERATE_APPS_TXT=1",
"INSTALL_APP_ARGS=--install-app erpnext --install-app lending",
"IMAGE_NAME=frappe/erpnext",
"VERSION=latest",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using VERSION=latest instead of pinning to a specific version like v15

Suggested change
"VERSION=latest",
"VERSION=v15",

Context Used: Context from dashboard - AGENTS.md (source)

},
{
"id": "frappe-lending",
"name": "Frappe Lending",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using version: "latest" instead of pinning to a specific version

Suggested change
"name": "Frappe Lending",
"version": "v15",

Context Used: Context from dashboard - AGENTS.md (source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants