Added the frappe lending template#665
Open
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Open
Added the frappe lending template#665Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
|
@greptile review |
| @@ -0,0 +1,550 @@ | |||
| x-custom-image: &custom_image | |||
There was a problem hiding this comment.
missing version: "3.8" at the start of the file
Suggested change
| x-custom-image: &custom_image | |
| version: "3.8" | |
| x-custom-image: &custom_image |
Context Used: Context from dashboard - AGENTS.md (source)
| "REGENERATE_APPS_TXT=1", | ||
| "INSTALL_APP_ARGS=--install-app erpnext --install-app lending", | ||
| "IMAGE_NAME=frappe/erpnext", | ||
| "VERSION=latest", |
There was a problem hiding this comment.
using VERSION=latest instead of pinning to a specific version like v15
Suggested change
| "VERSION=latest", | |
| "VERSION=v15", |
Context Used: Context from dashboard - AGENTS.md (source)
| }, | ||
| { | ||
| "id": "frappe-lending", | ||
| "name": "Frappe Lending", |
There was a problem hiding this comment.
using version: "latest" instead of pinning to a specific version
Suggested change
| "name": "Frappe Lending", | |
| "version": "v15", |
Context Used: Context from dashboard - AGENTS.md (source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.
Technical Details
frappe/erpnext:v15Greptile Summary
Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.
Key changes:
Issues identified:
version: "3.8"field at the start of docker-compose.yml (required by style guide)VERSION=latestin template.toml and meta.json instead of pinning to specific version likev15Positive aspects:
networks(unlike other frappe templates in the repo)portsandcontainer_namedirectivesConfidence Score: 4/5
Last reviewed commit: 9c637bb
Context used:
dashboard- AGENTS.md (source)