fix: clear old deployment records and logs keeping only active deployment#4554
Open
Irwnda wants to merge 2 commits into
Open
fix: clear old deployment records and logs keeping only active deployment#4554Irwnda wants to merge 2 commits into
Irwnda wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
clearOldDeploymentswas only deleting log files viarm -rf. The modal says "This will delete all old deployment records and logs, keeping only the active deployment", but records were never actually deleted.Changes
rm -fcommand beforeremoveDeploymentis called, sinceremoveDeploymentcannot handle remote log cleanup for application/compose deployments (serverId is not stored on the deployment record itself)Verification
[x] Triggered clear old deployments on an application: confirmed only the active deployment record and log remain
[x] Triggered clear old deployments on a compose: same result
[x] Verified remote server deployments are cleaned up correctly
Before
Before.fix.mov
After
After.Fix.mov
Note
removeDeploymentdoes not correctly delete log files for remote server deployments becauseserverIdis never stored on the deployment record for application/compose deployments.