FIX: replicaSets default to false after updating mongo due to default#4543
Open
linkthai wants to merge 1 commit into
Open
FIX: replicaSets default to false after updating mongo due to default#4543linkthai wants to merge 1 commit into
linkthai wants to merge 1 commit into
Conversation
set by create schema
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixes a bug where the replicaSets field on a MongoDB service would silently reset to false whenever any partial update was saved (e.g. editing ulimits, resource limits, or other advanced settings).
The root cause was that apiUpdateMongo is built from createSchema.partial(), but the base createSchema defines replicaSets: z.boolean().default(false). Zod applies that default even in a partial context when the field is absent from the payload — so any update that doesn't explicitly include replicaSets would write false to the database, overwriting the user's original setting.
Fix
Override replicaSets in apiUpdateMongo to z.boolean().optional(), removing the default so absent fields stay absent.