feat(security): display a masked webhook url by default with optional toggle#4506
Open
nktnet1 wants to merge 1 commit into
Open
feat(security): display a masked webhook url by default with optional toggle#4506nktnet1 wants to merge 1 commit into
nktnet1 wants to merge 1 commit into
Conversation
Contributor
Author
|
@Siumauricio I've rebased the branch to match the new git history for the However, would it be possible to limit the use of force-push for
I think it makes it difficult for contributors to have to rebase all their PR branches. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is this PR about?
The Webhook URL for triggering deployment contains a sensitive refresh token.
This should not be shown by default, as it could accidentally be leaked during an online meeting or video recording.
This pull request adds a client-side toggle button (default off) to control the visibility of the Webhook URL. See video further below.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Screenshots (if applicable)
Toggle off:
Toggle on:
Video demo:
demo-webhook-visibility-toggle.webm