Skip to content

feat(security): display a masked webhook url by default with optional toggle#4506

Open
nktnet1 wants to merge 1 commit into
Dokploy:canaryfrom
nktnet1:hide-webhook-url
Open

feat(security): display a masked webhook url by default with optional toggle#4506
nktnet1 wants to merge 1 commit into
Dokploy:canaryfrom
nktnet1:hide-webhook-url

Conversation

@nktnet1
Copy link
Copy Markdown
Contributor

@nktnet1 nktnet1 commented May 29, 2026

What is this PR about?

The Webhook URL for triggering deployment contains a sensitive refresh token.

This should not be shown by default, as it could accidentally be leaked during an online meeting or video recording.

This pull request adds a client-side toggle button (default off) to control the visibility of the Webhook URL. See video further below.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Screenshots (if applicable)

Toggle off:

toggle-off-image

Toggle on:

toggle-on-image

Video demo:

demo-webhook-visibility-toggle.webm

@nktnet1 nktnet1 requested a review from Siumauricio as a code owner May 29, 2026 05:45
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels May 29, 2026
@nktnet1 nktnet1 changed the title feat: display a masked webhook url by default with optional toggle feat(security): display a masked webhook url by default with optional toggle May 29, 2026
@nktnet1 nktnet1 force-pushed the hide-webhook-url branch from 2872830 to b174778 Compare June 2, 2026 11:12
@nktnet1
Copy link
Copy Markdown
Contributor Author

nktnet1 commented Jun 2, 2026

@Siumauricio I've rebased the branch to match the new git history for the canary branch.

However, would it be possible to limit the use of force-push for canary?

dokploy-activity-tab

 

I think it makes it difficult for contributors to have to rebase all their PR branches. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant