fix: avoid database connection during setup by using native exec#3624
Open
horsley wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: avoid database connection during setup by using native exec#3624horsley wants to merge 1 commit intoDokploy:canaryfrom
horsley wants to merge 1 commit intoDokploy:canaryfrom
Conversation
The setup.ts script imports execAsync from @dokploy/server, which triggers the entire package to load including lib/auth.ts. This module initializes betterAuth() with a database connection at import time, causing the setup script to fail with ECONNREFUSED before the database container is created. This fix replaces the import with Node.js native promisify(exec), avoiding the module side-effect that attempts database connection during setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup.ts script imports execAsync from @dokploy/server, which triggers the entire package to load including lib/auth.ts. This module initializes betterAuth() with a database connection at import time, causing the setup script to fail with ECONNREFUSED before the database container is created.
This fix replaces the import with Node.js native promisify(exec), avoiding the module side-effect that attempts database connection during setup.
What is this PR about?
Running pnpm run dokploy:setup fails with ECONNREFUSED error when the PostgreSQL database container doesn't exist yet. This is a chicken-and-egg problem: the setup script is supposed to create the database, but it fails before creating it because it tries to connect to the database during module import.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #2241
Screenshots (if applicable)