fix(traefik): add wildcard domain support for Traefik v3#3433
Open
AlemzhanJ wants to merge 1 commit intoDokploy:canaryfrom
Open
fix(traefik): add wildcard domain support for Traefik v3#3433AlemzhanJ wants to merge 1 commit intoDokploy:canaryfrom
AlemzhanJ wants to merge 1 commit intoDokploy:canaryfrom
Conversation
Traefik v3 changed the syntax for wildcard domain routing. Previously, Dokploy generated `Host(`*.domain.com`)` which doesn't work in Traefik v3. This change introduces a helper function that generates the correct routing rule based on domain type: - Regular domains: `Host(`domain.com`)` - Wildcard domains: `HostRegexp(`^.+\.domain\.com$`)` Affects both application domains (dynamic YAML config) and docker-compose domains (container labels). Refs: - https://doc.traefik.io/traefik/v3.0/routing/routers/ - https://community.traefik.io/t/how-to-create-a-router-rule-for-a-wildcard/19850
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.domain.com) in Traefik v3generateTraefikHostRule()helper that generates correct syntax based on domain type:Host(domain.com)HostRegexp(^.+.domain.com$)Problem
Dokploy currently generates
Host(*.domain.com)for wildcard domains, which doesn't work in Traefik v3. The correct syntax for Traefik v3 isHostRegexp(^.+.domain.com$).Changes
packages/server/src/utils/traefik/host-rule.tspackages/server/src/utils/traefik/domain.tspackages/server/src/utils/docker/domain.tsapps/dokploy/__test__/traefik/host-rule.test.tsapps/dokploy/__test__/compose/domain/host-rule-format.test.tsReferences